Frequent Time Outs

Question

Frequent Time Outs

AyauCode opened this issue 4 years ago · 28 comments

AyauCode commented 4 years ago

Bug description
All players on server will frequently time out and lose the ability to speak or hear then at a seemingly random time later the voice chat will reconnect. Relogging fixes the issue temporarily but players will soon have their voicechat time out again. Server CPU use is at 50% and memory usage at 4/6GB.

Steps to reproduce the issue

Create server
Players join
Try talking at random times to test if voice is connected. Attempt /voicechat test {user} to confirm time out

Expected behavior
Players connected to voice chat without timing out.

Log files
[https://gist.github.com/Setlock/5a37fa052e4167194b436774cdb6beb9](latest log)

Versions

1.16.4
35.1.36
1.1.5

Other mods
abnormals_core-3.0.6
AI-Improvements-0.3.0
AppleSkin-1.0.14
Aquaculture-2.1.12
AutoRegLib-1.6-47
BetterCaves-1.1.1
BetterMineshafts-2.0.1
BuildingWands-1.3.1
buzzierbees-3.0.0
bwncr-3.9.16
charm-forge-2.2.2
ChickenChunks-2.7.0.85
CodeChickenLib-3.5.1.408
create-v0.3e
DungeonCrawl-2.2.4
endergetic-3.0.0
FastFurnace-4.4.0
FastLeafDecay-v25
FastWorkbench-4.5.0
Hwyla-1.10.11-B78
jei-7.6.1.68
jeiintegration-6.1.1.11
JustEnoughResources-0.12.0.100
KleeSlabs-9.2.0
mcw-bridges-1.0.5
Morphes-4.2.68
MouseTweaks-2.13
Placebo-4.4.1
ProgressiveBosses-2.2.0
Quark-r2.4-302
repurposedstructures-2.3.4
SereneSeasons-4.0.0.86
swingthroughgrass-1.5.3
voicechat-1.1.5
XaerosMinimap-21.2.0.1
XPFromHarvest-1.2.1
YungsApi-4

AyauCode · Answer 1 · 2021-02-04T20:48:21.000Z

Lowering Server Sample Rate Had No Effect. Only 3 Players On Server When Testing.

henkelmax · Answer 2 · 2021-02-04T22:23:47.000Z

Thank you for explainung your issue.
The timeout of the test command is just related to a single "ping". If this times out, it doesn' mean you timed out from the voice chat. It just means the single packet that has been sent, hasn't arrived. This may occur because of packet loss.

But I think there is another problem that causes the connection issues after some time. I will look into it. I can't guarantee for it to get fixed soon, because it is a pain to debug this mod.

henkelmax · Answer 3 · 2021-02-04T21:03:26.000Z

Your log file is incomplete.

AyauCode · Answer 4 · 2021-02-04T21:10:17.000Z

Your log file is incomplete.

Sorry, Fixed Log File. Should now be full log.

henkelmax · Answer 5 · 2021-02-04T21:22:10.000Z

What do you mean with "players will soon have their voicechat time out again"?

AyauCode · Answer 6 · 2021-02-04T21:24:52.000Z

What do you mean with "players will soon have their voicechat time out again"?

When players initially join their voicechat is connected perfectly with response time around 30-50ms, however after some time normally 3-5 minutes and running the test command some players will time out. However, after waiting more time and running the test command again players will have "reconnected" and the test command will return time between 30-50ms. The time it takes for a voice chat time out, the time for reconnect, and the specific players who will lose connection seems to be random and not deterministic.

Also note, a relog will immediately fix the issue, only for them to time out again some minutes later.

Edit: for context current sample rate in server config is set to 13000

AyauCode · Answer 7 · 2021-02-04T21:45:59.000Z

WINMTR Test to Server with Output

anheetae · Answer 8 · 2021-02-11T20:09:57.000Z

I've had similar issues that seem to happen after long periods of inactivity. Additionally, my players seem to get their voices pitch shifted at random. This issue also does not resolve until disconnect/server restart.

henkelmax · Answer 9 · 2021-02-11T21:14:41.000Z

Thanks for letting me know. The pitch shifting is caused by changing the sample rate while the server is running.

henkelmax · Answer 10 · 2021-02-14T10:04:02.000Z

Can you try if it has been fixed with 1.16.5-1.0.3?

Deleted user · Answer 11 · 2021-02-15T02:24:49.000Z

Can you try if it has been fixed with 1.16.5-1.0.3?

can you please bring the same fix in the version 1.16.4 because i have a lot of other mods and i cant update the version so easy
i have the same problem, while my friends are speaking i see the icon beside their name but i cant hear them and the icon goes on and off while they speak. and if i do voicechat test often it is 660ms or timeout

henkelmax · Answer 12 · 2021-02-15T08:28:44.000Z

You can use 1.16.3 and 1.16.4 mods in 1.16.5 They just work, since nothing changed between these versions.

Deleted user · Answer 13 · 2021-02-15T12:00:29.000Z

You can use 1.16.3 and 1.16.4 mods in 1.16.5 They just work, since nothing changed between these versions.

oh ok thank you for that information, i will try it an say you if it is fixed or not

Deleted user · Answer 14 · 2021-02-15T13:58:43.000Z

If I know that the issue has been fixed, I will port it to older versions.

if you port it to 1.16.4 i can test it for you with 4 friends

Deleted user · Answer 15 · 2021-02-15T12:48:59.000Z

You can use 1.16.3 and 1.16.4 mods in 1.16.5 They just work, since nothing changed between these versions.

so you wont fix it in the 1.16.4?
because everyone who joins with 1.16.5 minecraft crashes everytime so i cant update

henkelmax · Answer 16 · 2021-02-15T13:43:41.000Z

If I know that the issue has been fixed, I will port it to older versions.

anheetae · Answer 17 · 2021-02-16T23:27:19.000Z

Was using 1.0.3! Will try 1.0.4 and update you.

anheetae · Answer 18 · 2021-02-16T20:49:43.000Z

My players are still experiencing the same issues on 1.16.5

henkelmax · Answer 19 · 2021-02-16T21:24:15.000Z

Which version are you using?

kgrubb · Answer 20 · 2021-02-17T22:16:12.000Z

on 1.0.5, I've noticed this in my logs whenever my voice chat cuts off:

[17Feb2021 16:51:36.980] [MicrophoneThread/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: java.lang.ArithmeticException: / by zero
[17Feb2021 16:51:36.980] [MicrophoneThread/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at de.maxhenkel.voicechat.voice.client.MicThread.sendAudioPacket(MicThread.java:136)
[17Feb2021 16:51:36.980] [MicrophoneThread/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at de.maxhenkel.voicechat.voice.client.MicThread.voice(MicThread.java:93)
[17Feb2021 16:51:36.980] [MicrophoneThread/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: 	at de.maxhenkel.voicechat.voice.client.MicThread.run(MicThread.java:39)

It looks like packetAmount is getting set to 0, causing a divide by zero issue in calculating bytesPerPacket.

I'm not very skilled at java dev, but would something like this work?

private void sendAudioPacket(byte[] data) {
        int dataLength = AudioChannelConfig.getDataLength();
        int packetAmount = (int) Math.ceil((double) data.length / (double) dataLength);
        if (packetAmount != 0) {
            int bytesPerPacket = data.length / packetAmount;
            if (bytesPerPacket % 2 == 1) {
                bytesPerPacket--;
            }
            int rest = data.length - bytesPerPacket * packetAmount;
            for (int i = 0; i < packetAmount; i++) {
                try {
                    new NetworkMessage(new MicPacket(Arrays.copyOfRange(data, i * bytesPerPacket, (i + 1) * bytesPerPacket + ((i >= packetAmount - 1) ? rest : 0))), client.getSecret()).sendToServer(client);
                } catch (IOException e) {
                    e.printStackTrace();
                }
            }
        }
    }

henkelmax · Answer 21 · 2021-02-18T08:04:31.000Z

Thanks for the PR. But I think this is not related to this issue.

anheetae · Answer 22 · 2021-02-18T21:16:33.000Z

1.04 had the same issues.

henkelmax · Answer 23 · 2021-02-19T09:30:49.000Z

This should be fixed wit 1.16.5-1.0.7

FrankyBaatz · Answer 24 · 2021-02-20T21:55:20.000Z

This should be fixed wit 1.16.5-1.0.7

when will there be a fix for 1.16.4

FrankyBaatz · Answer 25 · 2021-02-20T22:02:38.000Z

This should be fixed wit 1.16.5-1.0.7

when will there be a fix for 1.16.4

i tried the newest version still timing out

henkelmax · Answer 26 · 2021-02-20T22:11:31.000Z

Please send me your logs

FrankyBaatz · Answer 27 · 2021-02-20T22:14:00.000Z

Please send me your logs

20.02 23:12:29 [Server] VoiceChatPacketProcessingThread/INFO [FrankyBaatz: Request timed out]
20.02 23:12:23 [Server] Server thread/INFO [FrankyBaatz: Packet sent. Waiting for response...]
20.02 23:12:23 [Server] Server thread/INFO [FrankyBaatz: Sending packet...]
20.02 23:12:06 [Server] VoiceChatPacketProcessingThread/INFO [voicechat/]: Successfully authenticated player 8ffaf706-dd05-4136-a8b5-fd7b4fb54596
20.02 23:11:52 [Server] Server thread/INFO [voicechat/]: Sent secret to FrankyBaatz

henkelmax · Answer 28 · 2021-02-21T07:42:16.000Z

Please send me the full logs from both server and client. Please use github gist or something.

Share to