Simple Voice Chat

Simple Voice Chat

31M Downloads

PTT & whisper keys handled incorrectly

isXander opened this issue ยท 1 comments

commented

Bug description
The afformentioned binds are handled inside of a keyboard event. This is incorrect. Usually, mods handle this inside the game tick, which you have done for all other binds. This is an issue for me as it breaks compatibility with mods that emulate key presses. Namely, my mod, Controlify. This prevents the use of controller bindings on SVC as no key event is actually invoked.

Steps to reproduce the issue

  1. Install Controlify with SVC
  2. Bind PTT or whisper
  3. Attempt to use

Expected behavior
PTT and whisper should be handled like all other keybinds so they work correctly.

Versions

  • Minecraft version - 1.20.1
  • Quilt loader
  • v2.4.16
commented

This is done on purpose, as these keys need to work globally. This means, it has to work, when Minecraft key input events are blocked, like when you are in a text box.