Simple Voice Chat

Simple Voice Chat

46M Downloads

Severe performance impact due to Paper reflection

R00tB33rMan opened this issue ยท 2 comments

commented

Confirmation

  • I have read the wiki

Bug description

https://spark.lucko.me/OutWpjkVp4 - It appears that your reflection method is uncached. I'd suggest caching this method and improving the issue by improving how payload is handled for packet sending.

Minecraft version

1.21.1

Mod/Plugin version

2.5.27

Mod/Plugin loader and version

UniverseSpigot 1.21.1 (Plus)

Steps to reproduce

  1. Start the server
  2. Let lots of players join
  3. Run a spark report
  4. See the impact

Expected behavior

voicechat consuming virtually no resources (or at least close to none).

Log files

https://spark.lucko.me/OutWpjkVp4

Screenshots

No response

commented

I am aware of this, but there already is a native paper version of the plugin. I might look into it if the bukkit plugin keeps working with the paper hard fork.

Edit:
If this is really urgent or important to you and you need it in the bukkit plugin, feel free to open a PR.

commented

Just FYI @R00tB33rMan this has been partially implemented (for 1.20.3+) in 25faed1.
But I'd still recommend the paper version if you want the best experience.