Confirmation

• I have read the wiki

Bug description

Im having trouble with the Connection#getGroup method. Im making a plugin that handles calls, and when in a call, players get put in a group. I want to check which players are in the group, to display to those that might not have simple voice chat installed.
Even after i set the group directly before, getGroup() returns null, no matter if im in a group or not. Heres the related code snippet and its output:

connection.setGroup(group);
System.out.println(group); // the group that gets players added to
System.out.println(connection.getGroup()); // this is always null
if (connection.isConnected() && connection.getGroup() == group) {
    result = true;
    System.out.println("same group");
} else {
    System.out.println("not the same group");
}

Related log output:
https://gist.github.com/008kevin/a88e31eb9a1ec7e0b550bcc11c7b116d#file-latest-log-L212-L218

From what i've been able to figure out, the connection's group never actually gets set, but the group id is stored in the state, which you could return the group from instead. I've tried to do it myself, but i could not figure out how to build the plugin using gradle for the life of me 😅

Thanks for the help!

Minecraft version

1.21.4

Mod/Plugin version

voicechat-bukkit-2.5.27.jar

Mod/Plugin loader and version

Fabric Loader 1.21.4-2.5.27

Steps to reproduce

1. set the group using the api, or join a group in the client
2. get the connection of the player in the extension plugin
3. try to get the group of the connection using connection.getGroup()
4. it will always return null

Expected behavior

The player's group should be returned if there is one

Log files

https://gist.github.com/008kevin/a88e31eb9a1ec7e0b550bcc11c7b116d

Screenshots

No response

The VoicechatConnection object represents the state of the player as snapshot at the time of getting it. This is done for performance reasons. You always need to re-fetch the connection to get an updated version of the state.

This is also not exclusive to bukkit. It behaves like this on all platforms. I will update the documentation to make that clear, thanks!

Thanks for the help!