SimpleHarvest

SimpleHarvest

20M Downloads

SimpleHarvest doesn't work with Sandwichable

Opened this issue · 2 comments

commented

Hello. For some reason, Sandwichable crops are not right-clickable. This mod has the right tag for Simple Harvest and I set up the config correctly.

{
  "exhaustionPerHarvest": 0.005,
  "additionalLogging": false,
  "crops": [
    {
      "block": "minecraft:wheat",
      "states": {
        "age": "7"
      }
    },
    {
      "block": "minecraft:nether_wart",
      "states": {
        "age": "3"
      }
    },
    {
      "block": "minecraft:carrots",
      "states": {
        "age": "7"
      }
    },
    {
      "block": "minecraft:potatoes",
      "states": {
        "age": "7"
      }
    },
    {
      "block": "minecraft:beetroots",
      "states": {
        "age": "3"
      }
    },
    {
      "block": "sandwichable:cucumbers",
      "states": {
        "age": "4"
      }
    },
    {
      "block": "sandwichable:lettuce",
      "states": {
        "age": "4"
      }
    },
    {
      "block": "sandwichable:onions",
      "states": {
        "age": "3"
      }
    },
    {
      "block": "sandwichable:tomatoes",
      "states": {
        "age": "4"
      }
    }
  ]
}
commented

@FlamingCherry This is neither of their fault, per se, but it is odd. seeds.json is a tag file that standardizes which items are seeds for the corresponding crop item. Harvest seems to be pushing a convention that all seed items should be marked with this tag, which is a responsibility then put on other modders (in the case of this issue the dev of Sandwichable). I think it's a bit of a redundant convention since you can literally figure out which item is the seed item for the block you're breaking in code. I've done so in the above PR. I also published a build with the fix on my fork here

commented

UPD: If you make a separate datapack for the world with the seeds.json file, then everything starts working as it should. But why isn't the tag loaded directly from the mod? Is this a Sandwichable issue or Simple Harvest? 🤔