Simply Backpacks

Simply Backpacks

Mods
11M Downloads

Opening a backpack passes clicks through to the world

quat1024 opened this issue ยท 3 comments

commented

Describe the bug

  • Hold a bag in your main hand and a block in your other hand.
  • Right click.
  • You open the bag and place the block at the same time.

Happens with anything that has a right click behavior (this is pretty disastrous with a CAD from Psi, for example x) )

What I expected would happen
You wouldn't place the block.

Fix
Return SUCCESS instead of calling super here:

simplybackpacks/src/main/kotlin/com/flanks255/simplybackpacks/items/ItemBackpackBase.kt

Line 91 in 818d503

override fun onItemRightClick(worldIn: World, playerIn: EntityPlayer, handIn: EnumHand): ActionResult<ItemStack> {

Versions
Simply Backpacks 1.2.2
Forge 14.23.5.2648
(it's in FTB Academy with a bunch of other mods added but I don't think the exact modlist is important)

commented

Nice catch, ill test it out and update it sometime soon.

commented

Sorry for the delay, forgot about the problem.
Fixed in:
1.16.1: 6cde85e
1.15.2: b66f9b1
1.14.4: 53c0aa6
1.12.2: bdfeaf6

commented

Yes, this happens with offhand (which is what it's called) items, I keep placing my torches... shift+click is also doing this...