Simply Conveyors & More

Simply Conveyors & More

1M Downloads

Baffling Behavior on 1.11.2 versions higher than 3.0.6

kragnoth opened this issue ยท 5 comments

commented

After upgrading for bugfixes/new blocks on 1.11.2 for anything higher than 3.0.6, I can no longer break blocks.

Do you attach to the block break event and forget to close out your if/else/then statements? Mod conflict?

Logs look useless in diagnosing this, just figured I'd let you know I tracked it down to this mod from mods I updated after going through the obvious ones first. (I simply did not expect this one... always the last one you test though, because after you find it you stop :P)

edit: Looks like something relating to SimplyConveyorsEventHandler.java

You are using != null on itemstacks, I believe for 1.11.2 you need to use !itemstack.Empty. Not sure how you would make that compatible with 1.10.2 though, maybe compatlayer since you are already using that library?

commented

Hey, I'm not entirely sure why the bug is happening as I wasn't able to re-produce it. I've fixed the != null sections in the event handler to be != ItemStackTools.getEmptyStack() (I have no idea why those are there, I double-check and triple-check all while using Ctrl + F). Those were unrelated to block breaking in it's entirety however. My Worker Gloves do attempt to increase the block reach distance while in the off-hand, so I've disabled those to see if it may fix the issue as well.

I have two test builds for you. One is just with those applied event handler fixes, and one is with those fixes AND the worker gloves functionality disabled. If you could try these and get back to me which ones (if any) fix the issue it would be great.

Test Build 1 - Event Handler Fixes

Test Build 2 - Fixes + Disabled Worker Gloves

If either of them don't fix the issue, please make sure again it's not another mod. I'm not sure I could be doing anything else which would cause this issue.

commented

Downloading now to test, thanks. Sorry for the long wait, have a bit of a fever so I've been resting most of the day.

commented

It's fine. I hope it gets better soon :P.

commented

Test Build 2 - Fixes + Disabled Worker Gloves worked. Oddly enough. Wonder which one of my mods causes a conflict to cause that to even do anything.

commented

Simply Conveyors 3.1.1b is out now, which fixes this issue and more.