Simply Hot Springs

Mod version: 0.3.0
Minecraft version: 1.19.2
Forge version: 43.2.4
Trident with riptide does not activate in Hot Spring Water.
Is this intended behavior or a missing feature?

This is not something I can reasonably fix. Unfortunately, Forge's 1.19 fluid overhaul leaves a lot to be desired. It was apparently created with the goal of allowing more configurability, but ironically makes it harder to create a fluid that behaves similarly to vanilla water. They moved many water fluid behaviors that previously used to work with any fluid in the water tag to only work specifically with vanilla minecraft water.

Here's a list of some of the behaviors that you may expect of Hot Spring Water, but don't actually work:

Simply-Hot-Springs/src/main/java/connor135246/simplyhotsprings/SimplyHotSprings.java

Lines 31 to 48 in b34d8a2

    
           // TODO ISSUES WITH FORGE'S FLUIDS 
        
           // if our fluid is NOT in the #water tag: 
        
           // - fishing bobbers will sink to the bottom 
        
           // - lava flowing on top doesn't make stone 
        
           // - dirt below it can have grass grow on it if the fluid level is below 8 (non-full block) 
        
           // - respawn anchors will damage blocks even if they have the fluid next to it 
        
           // being in the #water tag doesn't fix these: 
        
           // - squids, etc suffocate in it. blazes and endermen don't take damage in it. (#9154) 
        
           // - undead mobs will drown in it 
        
           // - witches don't drink water breathing in it 
        
           // - conduits don't give conduit power while in the fluid; turtle helmet doesn't count down water breathing 
        
           //   - related: air bar doesn't appear in the fluid if your air bar is full (such as due to conduit power or turtle helmet) even though the fluid can drown you (inconsistent with water) 
        
           // - riptide doesn't work in it 
        
           // - dig speed isn't reduced 
        
           // - waterVisionTime does not advance 
        
           // - no underwater ambience or music 
        
           // other issues: 
        
           // - physics applied to your movement are twice as strong as they should be (#8897)

Does NeoForged fix these issues in More recent MC versions?

Maybe. I haven't tried using NeoForged. Personally I'm just not interested in porting this mod to newer versions at the moment.

	// TODO ISSUES WITH FORGE'S FLUIDS
	// if our fluid is NOT in the #water tag:
	// - fishing bobbers will sink to the bottom
	// - lava flowing on top doesn't make stone
	// - dirt below it can have grass grow on it if the fluid level is below 8 (non-full block)
	// - respawn anchors will damage blocks even if they have the fluid next to it
	// being in the #water tag doesn't fix these:
	// - squids, etc suffocate in it. blazes and endermen don't take damage in it. (#9154)
	// - undead mobs will drown in it
	// - witches don't drink water breathing in it
	// - conduits don't give conduit power while in the fluid; turtle helmet doesn't count down water breathing
	// - related: air bar doesn't appear in the fluid if your air bar is full (such as due to conduit power or turtle helmet) even though the fluid can drown you (inconsistent with water)
	// - riptide doesn't work in it
	// - dig speed isn't reduced
	// - waterVisionTime does not advance
	// - no underwater ambience or music
	// other issues:
	// - physics applied to your movement are twice as strong as they should be (#8897)

Share to