Simply Improved Terrain

Simply Improved Terrain

2M Downloads

Conflict with CaveBiomesApi

KKotik opened this issue · 13 comments

commented

When CaveBiomesApi 1.1.0 installed with Simply Improved Terrain some conflicts happens.
Like terrain starting to be flat and missing water even in oceans.
image
image
image
image

commented

CaveBiomesApi just released new version (1.2.0) that should fix that biome coloring issue.

commented

in other news, this can be closed since i did a small rollback onto a feature that caused many incompat issues, and that allowed simply improved terrain generation to get back to normal! c: i'll release the update today

commented

I have the same or a similar issue like there are no oceans or rivers in the world its just grass allover and it says its the ocean biome for example bu it's just green all over the place.

commented

There is an update happened to CaveBiomesApi and Caves And Cliffs backport. So people will massively report it and deal with.

commented

Hello, I saw updates on Fabric version recently. How thing are going with forge? With this issue and #10?

commented

Hmm... this could be related to the changes Cave Biome API applies in order to get the 3D overworld biomes. Simply Improved Terrain looks at y=0 to determine the biome used for 2D blending (mirrored from Vanilla, where Y coordinate doesn't matter in the 2D biome lookup). Cave Biome API changes some things to look at y=64 instead.

Going to see if it's as simple as changing this value in Simply Improved Terrain. Thanks for the report!

commented

How things are going? Could it be better to check biomes from the middle or top point of the world instead. For safety.

commented

I think I'll first try sampling from y=64 like Cave Biomes does. I've had a number of things to bounce between the past few days, but I do want to get this resolved! I'm going to test a number of mod pairings to be certain before pushing the update with this change, but I don't currently forsee it'll cause any issues.

commented

It fixed the issue, but another showed up.

Before:

After:

Also FWIW the land issue seems to not be present in Cave Biomes 2.0, only 1.1. With 2.0, I get the discolored surface patches, but oceans aren't turned into land, regardless of whether I change to y=64 in the biome lookup.

Going to keep looking into this.

commented

Cave Biomes 2.0 is old versiong. A bit confusing, but 1.1 is latest. Next update author will fix biome colors, this issue seems to be on other mod side.

commented

I think the issues is fixed, only what was happening from SIT side was terrarin generation. The biome coloring missing even in CaveBiomesApi itself, you could test it out without any other mods, to make sure and understand what I am talking about.

commented

Fabric verison of CaveBiomeApi already have update that already fixed it according to changelog of 1.2. It's only need to be ported to forge. (Still confusing that in changelog it says 2.0, but it's 1.2)

image

commented

my bad 👀 i forgot to rename it to 1.2