Simply Improved Terrain

Simply Improved Terrain

2M Downloads

Conflict with BetterEnd crash

IK4MS opened this issue · 5 comments

commented

Log (includes mods): https://paste.ee/p/VAzz5

The game often crashes while trying to generate new chunks. Wasn't entirely sure whether to post this here or on the betterend github.
Thanks for the mod, by the way.

commented

Thanks for the mod, by the way.

I just want to echo this -- I really like this mod.

I filed an issue for Better End because only Better End is mentioned in the stack trace. Hopefully this may save the next person a little time.

commented

FWIW paulevs has provided a suggested fix for Simply Improved Terrain in the Better End issue.

commented

Duplicate of crash reason:

Hi, the reason can be here. As this is CallbackInfoReturnable on HEAD - it will replace sampleHeightmap, and if all conditions in cycle fail - cir.cancel() will set function return value to null. As a result you will get NullPointerException in features on heightmap sampling, which you can see in your logs.

Proper solution will be replace cir.cancel() with cir.setReturnValue(OptionalInt.of(0)) in Simply Improved Terrain

commented

Makes sense! Good find. May also resolve #18. Aiming to get the fix out on curseforge within the hour.

commented

Testing as fixed in 0.4.0.3 for me. :)