Simply Swords [Fabric & Forge]

Simply Swords [Fabric & Forge]

23M Downloads

Config lag

someaddons opened this issue ยท 2 comments

commented

image
The config is creating unnecessary lag through loading a file from disk on access

commented

The config system will be reworked in 1.21.x versions of the mods.
That being said, we use this on an active server and do not see any issues in spark profiling or in gameplay. Simply Swords uses up very little of server tick

commented

Your code will re-read the configuration file and iterate through all the configuration items each time it gets the configuration value. Besides, you read the configuration file in containertick, but you don't have any cache. Assuming there are 100 config keys and 100 swords, the server will execute 100,000 try-catches and 500 file IOs per tick. I don't want to swear but you really did a bad job