Simply Swords [Fabric & Forge]

Simply Swords [Fabric & Forge]

23M Downloads

Weapons can spawn with invalid enchantments.

Closed this issue ยท 1 comments

commented

Have you performed isolation testing?
Yes

Describe the bug
Weapon types from Simply Swords (not uniques) spawn naturally with Mace and Trident Enchantments. This was fixed for armour enchantments, but these two enchantment sets must have gone under the radar.

Note that they cannot be enchanted with these enchantments through other means, only found naturally in chests.

To Reproduce

  1. Set the spawn rate of weapons up to 100%
  2. Place down chests (or use /loot) continuously until one spawns with a disallowed enchantment.

Expected behavior
The following enchantments can never appear on a weapon spawned naturally:

  • Breach
  • Impaling
  • Density

Screenshots
Image
Image

Additional Info:

  • Modloader: All
  • Minecraft Version: 1.21.1
  • Mod Version: 1.60.11
  • Environment: All

Erroneously, the weapons cannot spawn with other trident enchants - such as channelling, loyalty or riptide. Maybe because drowned can't spawn with those enchants either (?)

They also can't spawn with Wind Burst, which I assume is because wind burst cannot be applied via an enchanting table - but the trident enchantments can be applied via enchanting table and are still absent, so i'm unsure.

commented

Fixed in #277