Simply Swords [Fabric & Forge]

Simply Swords [Fabric & Forge]

16M Downloads

Wildfire effect causing players to crash

VeggeieDude opened this issue ยท 8 comments

commented

Heya! A friend playing on my server crashed because of the Wildfire effect and couldn't rejoin until I disabled the effect on the config.

Fabric 1.19.2, mod version 1.40.0

I'll send logs soon!

commented

Thanks for the report!

Looking at the code, I can see potential for a null pointer exception when attempting to get the attacking entity for that effect.
Will need those logs to be sure.

commented

Can't seem to replicate this issue on my end. Will need those logs when you get a chance.

commented
commented

Thank you!
That looks like the null pointer exception I had expected it to be.
I should be able to fix this on my end pretty easily, but I'm curious how they managed to trigger the crash.
Does your friend remember any details about the crash that might help me reproduce the issue on my end?

commented

So her and another friend were fighting each other lol. The one that was crashing had a runic rapier weapon, while the other had a runic ring weapon. The runic ring was the one with the Wildfire effect. After hitting each other a few times she crashed lol

commented

Now fixed in the latest version.

commented

Thanks for that info!
I'll be deploying a fix today for versions 1.19.2 & 1.19.3.

commented

This bug exists in the latest release for 1.18.2, any plans to revisit to fix?