Sinytra Connector

Sinytra Connector

Mods
12M Downloads

Combatify and its many Mixin/Adapter issues

Alexandra-Myers opened this issue ยท 0 comments

commented

Mod Name

Combatify

Mod Homepage

https://github.com/Alexandra-Myers/Combatify/tree/1.21.1

Minecraft version

1.21.1

Describe the bug

Adapter fails to adapt InvulnerabilityMixin (only one injection point), PlayerMixin's hurtCurrentlyUsedShield/changeUsedShield ModifyExpressionValue, and if both are removed there is a mixin crash.

Steps to reproduce

  1. Build and add the latest commit for 1.21.1 to a NeoForge instance with the bare minimum dependencies
  2. Run the game
  3. Observe that Adapter fails to adapt InvulnerabilityMixin
  4. Comment out the one ModifyExpressionValue in InvulnerabilityMixin and repeat steps 1 and 2
  5. Observe that Adapter now fails to adapt PlayerMixin#changeUsedShield
  6. Repeat step 4 but for PlayerMixin#changeUsedShield, then repeat steps 1 and 2
  7. Observe a bizarre unhandled crash

Logs

https://gist.github.com/Alexandra-Myers/a309904975a8f1bcc28ff79d1ddf2667 (for the primary issue, though none of the logs help much)

Additional context

for the unhandled crash after digging through the first two issues, this is all information about it:https://gist.github.com/Alexandra-Myers/ff483fd53ea6eed7ecabb4f2fd3cc29d