![Skin Layers 3D (Fabric/Forge)](https://media.forgecdn.net/avatars/thumbnails/426/742/256/256/637657627491599401.png)
Jacket layer clips with leggings
hibiii opened this issue ยท 15 comments
Steps to reproduce
- Have a skin which jacket layer intersects with the top part of leggings
- Wear leggings in game with no chestplate
This bug might also affect other combinations, like armor textures that are bigger than they're intended (ex.: sleeves and gloves for chestplate). On my skin, the sides of the jacket layer clip with the sides of the leggings.
The issue is that the body and legs are right next to each other. Now you have the 2nd layer that is bigger around them, so they have to intersect. This is in vanilla too, just less noticeable. I guess the simplest fix is to not have things at the top of the legs/bottom of the body.
Perhaps you could just slightly deflate the jacket layer? I like walking around in pants and shoes only and I end up seeing the clipping a lot.
I've noticed that it just barely clips out so a very minor adjustment would probably be best. :)
I'll probably make it a config value, since everyone seems to have different preferences.
I don't think this mod should even be moving the pixels on the outer layers by default. Ideally it should look just like vanilla, just with geometry added to the sides of pixels. This is an edit of @not-holar 's screenshot to show what I mean:
Please check the the latest build under Actions, it adds a config where you can change all the settings in that regard.
I tried using 3dSkinLayers-1.0.1-dev.jar
from https://github.com/tr7zw/3d-Skin-Layers/actions/runs/1210750560 and the mod doesn't seem to work at all, skins just look as they do in vanilla.
Edit: oh, I'm supposed to use just the new 3dSkinLayers-1.0.1.jar
I set all the values to 1.01 and it seems the body and leg layers are indeed both shifted 1 pixel up. (I should clarify that the only outer layer on the leg texture of this skin is the 4x4 bottom of the foot, if you look closely, you can see it ending up all the way on the second pixel from the bottom)
Edit: this is probably the cause
The offsets look good now, what i think would be wise with the arm layer is to calculate it based on the current voxel size instead of having it as a constant, so that it always remains centered around the arm
Not really, with the correct offset value for 3/4px arms it should be just correct. The issue is that we are talking about really really small movements to get it to the correct position, so it's just lots of try and error. I hope that for now this is a smaller issue, more important to get out the configs and a Forge build.
Yea the arms are tricky because of the 3px/4px arms, so I had to approximate move the entire thing, and guess it's ever so slightly off. And the -= 1 find is a good copy and fail find from the 1.16 src that I just didn't questions^^.
The leg layer might now be a tiiiny bit too low. Maybe I'll move it to the config too.