Skyblock Builder

Skyblock Builder

Mods
6M Downloads

Cannot allow teams to modify their spawn if membership management is disabled.

FunnyMan3595 opened this issue ยท 1 comments

commented

Minecraft version

1.19.2

LibX version

1.19.2-4.2.8

Skyblock Builder version

1.19.2-4..2.6

Forge version

43.2.6

The latest.log file

n/a

Issue description

The config has separate settings for team management and team spawn management. For some reason, the code enforces the team management setting on team spawn management as well:
https://github.com/MelanX/SkyblockBuilder/blob/1.19.x/src/main/java/de/melanx/skyblockbuilder/commands/TeamCommand.java#L266
https://github.com/MelanX/SkyblockBuilder/blob/1.19.x/src/main/java/de/melanx/skyblockbuilder/commands/TeamCommand.java#L315
https://github.com/MelanX/SkyblockBuilder/blob/1.19.x/src/main/java/de/melanx/skyblockbuilder/commands/TeamCommand.java#L372

The pack I'm building needs to force players to be in a team by themselves, so I've disabled team management. However, it would be highly desirable for them to be able to move their spawn point, so that visit and home don't spawn you in a weird place.

It's very unexpected to me that team spawn management can be set separately in the config, but requires team management under the hood.

Steps to reproduce

  1. Install mod.
  2. Disable Utility -> selfManage, enable Utility -> Spawns -> modifySpawns.
  3. Start Minecraft.
  4. Create a team for yourself.
  5. Attempt to modify the team's spawns.
  6. Observe failure message.

Other information

No response

commented

<3