Snow! Real Magic! ⛄ (Fabric)

Snow! Real Magic! ⛄ (Fabric)

7M Downloads

Foliage generated by No Man's Land doesn't get covered by snow in worldgen (even vanilla plants)

mosharky opened this issue · 1 comments

commented

Mod loader

NeoForge

Minecraft version

1.21.1

Mod version

12.0.4

Modloader version

NeoForge 21.1.162

Modpack info

No response

[IMPORTANT] If bug:

  • I have confirmed this bug is reproducible on a minimal setup, not a modpack with many other mods.

[IMPORTANT] If bug: The latest.log file, not the crash report

https://mclo.gs/5Mdw0V8

Issue description

For some reason, flowers/plants generated by No Man's Land aren't covered by snow in world generation. This even happens with vanilla plants, so its 100% not a tag missing from these blocks.

An example that would be simple for us to investigate is their snowy_plains biome replacement (link), they added nomansland:flower_patches/flowers_frosted (link). The configured feature only places vanilla flowers (link), so I really don't know why it wouldn't generate the flowers with snow on them. It might have do with the configured feature's config using minecraft:dual_noise_provider to place the flowers which seems like an odd choice, but I'm not too well versed in worldgen modding.

EDIT: I might've found what's causing the incompatibility. No Man's Land seems to be using an extra feature generation step. It has 12 steps instead of the 11 I'm seeing in vanilla's snowy_plains biome json (for reference). I've never seen 12 before, is that a vanilla thing?

Here's a screenshot:
Image

commented

quick update, it's definitely caused by No Man's Land. I can close this once they fix it I guess