Snow! Real Magic! ⛄ (NeoForge)

Snow! Real Magic! ⛄ (NeoForge)

40M Downloads

[1.15 & 1.16] Structurize compatibility crash

Nightenom opened this issue · 5 comments

commented

Hello,
a player reported a crash to our mod (Structurize) which is our fault but it's way easier to solve for you than for us.

Description: the crash (issue link) occurs from your call (link) in Forge code because our current version of the mod doesn't handle fake world rendering in vanilla-like way. It's not feasible for me to use ClientRenderCache along with current rendering code.

Proposed solution: create a marker interface for you to determine whether to use ClientRenderCache or tile entity world directly

This issue will most likely become invalid with a rewrite of our mod (no eta right now)

commented

If this forge issue (link) will become valid I can make PR which will also solve this issue

commented

Looks like it is a Forge bug. The way for me to manipulate cache is very limited

commented

Also when snow lands on structurize roofing blocks it turns them into blocky stairs, likely because they are coded over stairs. Is there any way to either blacklist the snow falling on them or render the snow with the roof instead of the base stair hitbox?

commented

@Snownee you should be able to use optional in 1.16 now, 1.15 is still under review (not sure why tho)
something like MinecraftForgeClient.getRegionRenderCacheOptional(te.getWorld(), pos).orElse(te.getWorld())

commented

@Snownee you should be able to use optional in 1.16 now, 1.15 is still under review (not sure why tho)
something like MinecraftForgeClient.getRegionRenderCacheOptional(te.getWorld(), pos).orElse(te.getWorld())

Good to know. Thank you Nightenom!