Sodium Extra

Sodium Extra

Mods
25M Downloads

Can't disable fireworks particle

Zailer43 opened this issue ยท 4 comments

commented

Make sure you are not opening a duplicate.

Minecraft version.

1.19

Sodium Extra version.

sodium-extra-0.4.6+mc1.19-build.47

Sodium version.

sodium-fabric-mc1.19-0.4.2+build.16

What happened?

I can't disable firework explosions particle (flash)

Relevant log.

https://gist.github.com/Zailer43/b4b7a4e244c2aea03e1788324c44511a

Additional information.

2022-07-26_16 08 05

The wiki says that the effect of firework explosions is called flash while the trail as it goes up is called firework
https://minecraft.fandom.com/wiki/Particles

commented

It's just the flash of light, not the actual explosions. The code dynamically checks all registered particles and creates a toggle based on that. The previous code was hardcoded groups and it only disables firework.
Old code:

sodium-extra-fabric/src/main/java/me/flashyreese/mods/sodiumextra/mixin/particle/MixinWorldRenderer.java

Lines 69 to 73 in 70cc190

if (!SodiumExtraClientMod.options().particleSettings.firework) {
if (parameters == ParticleTypes.FIREWORK) {
callbackInfo.setReturnValue(null);
}
}

New code:

sodium-extra-fabric/src/main/java/me/flashyreese/mods/sodiumextra/mixin/particle/MixinWorldRenderer.java

Lines 36 to 44 in af8ad53

if (SodiumExtraClientMod.options().particleSettings.particles) {
Identifier particleTypeId = Registry.PARTICLE_TYPE.getId(parameters.getType());
if (!SodiumExtraClientMod.options().particleSettings.otherMap.getOrDefault(particleTypeId, true)) {
callbackInfo.setReturnValue(null);
}
} else {
callbackInfo.setReturnValue(null);
}
}

Let me know if you can replicate this in the older version.

commented

Okay, after investigating further I found have found the underlying issue.

commented

Let me know if you can replicate this in the older version.

In 0.4.4 in 1.18.2 it didn't work either

commented

Fixed in 2441a41