Iris compatibility might be broken
mrjasonn opened this issue · 9 comments
Seems like its using the old class before the rename in Iris 1.7.0 net.coderbot.iris.vertices.IrisVertexFormats and there might be some other things as well broken with Iris 1.7.0, please check if that is the case
@FlashyReese because of the fact of what I have said above, if you haven't, you may want to investigate if Iris has actually made the compat not needed because Iris 1.7.0 did make a lot of changes to the code and might already contain what is needed.
I already said I did so in #390 (comment)
Seems fine on my end
hmm... I would suggest removing the compatibility class if you find out if not needed after a bit more investigation, and if it is still needed maybe update it to be future-proof
@FlashyReese If you do some more testing on this (if you haven't yet or not enough including use more shader packs for test) and find out the compat is not needed, then the best choice might be to remove it (if not make it do nothing but still available for viewing)
It's still needed I looked at Iris and it still has this in it.
Hmm... @FlashyReese I have seen that the issues regarding this beacon compatibility with Iris have been just crashes and you haven't observed one (as you were able to take a screenshot of the beacon beam), so I think you may want to ask @IMS212 if anything can be removed with regards to Iris compat
That won't be necessary; I have already released a fix for it. Removing the compatibility won't be possible unless I throw out the entire beacon beam rendering optimization. Also, please provide crash logs next time.
That won't be necessary; I have already released a fix for it. Removing the compatibility won't be possible unless I throw out the entire beacon beam rendering optimization. Also, please provide crash logs next time.
@FlashyReese I haven't experienced a crash as I have not even seen a beacon with shaders in 1.20.5 and 1.20.6, I was just trying to help by pointing out if there is an issue in the code.