Compatibility issue with continuity. Connected blocks have Z-fighting
djmrFunnyMan opened this issue · 15 comments
Bug Description
When using the continuity mod with a connected textures resource pack you will see Z-fighting on the connected textures.
Reproduction Steps
Install sodium and continuity. Use this resourcepack: https://github.com/xalixilax/xali-s-Enhanced-Vanilla-16x (github link because CF/modrinth downloads are corrupted)
Place down connectable blocks in a line (netherrack and magma in my case). You should see Z-fighting occur on some blocks (seems to be random in my case it occurs on these 6 blocks)
Log File
Not relevant
Crash Report
Not relevant
This is going to be fixed once the solution proposed in #2004 gets implemented - it is in the Sodium 0.7 milestone.
Actually it's gonna be fixed in Sodium 0.6 thanks to this ea01727 (I think)
Nvm apparently
Has that commit fixed this?
Using that commit doesn't allow me to use any CTM resourcepack
https://gist.github.com/djmrFunnyMan/88553d6aba1e8f258705387fd5335508
Has that commit fixed this?
Using that commit doesn't allow me to use any CTM resourcepack gist.github.com/djmrFunnyMan/88553d6aba1e8f258705387fd5335508
Can you try with the multiloader branch or with Indium?
Using this build it is not fixed
https://github.com/CaffeineMC/sodium-fabric/actions/runs/8903395759
I literally tested it on a built which had the commit in question and it wasn't fixed. Wdym it can't be tested. The major difference between the version I used and the one you sent me is yours is on 1.20.5 and mine is on 1.20.4 which shouldn't affect anything
I literally tested it on a built which had the commit in question and it wasn't fixed. Wdym it can't be tested. The major difference between the version I used and the one you sent me is yours is on 1.20.5 and mine is on 1.20.4 which shouldn't affect anything
The 1.20.4/multiloader-0.6 branch doesn't have all the CVF changes iirc
This issue wasn't closed because the described problem still exists. Block overlays are not entirely fixed with the improvements to our vertex format. It still needs further investigation/work.
(Caused by compact vertex format)
so it's not caused by the Compact Vertex Format, it's caused by the reorientation of the quad?
If yes, please change the title of the bug report
Just in case you don't already know, the resourcepack I use is https://github.com/xalixilax/xali-s-Enhanced-Vanilla-16x
So if you wanna reproduce the issue yourself use that. The z-fighting does appear to happen more frequently between netherrack and magma than with any other block, so that should make it easier to reproduce.
(Also do download the resourcepack from the rep, the curseforge and modrinth downloads are corrupted and will break your mipmaps and just not work properly)