[NeoForge] Sodium Ignores `BakedQuad`'s `isShade()` and `hasAmbientOcclusion()`

Question

[NeoForge] Sodium Ignores `BakedQuad`'s `isShade()` and `hasAmbientOcclusion()`

Kneelawk opened this issue 2 months ago · 3 comments

Kneelawk commented 2 months ago

Bug Description

This issue is occurring with Sodium mc1.21-0.6.0-beta.2-neoforge which is the latest version of Sodium as of this writing.

I have a mod where my model implements IBakedModelExtension.getQuads(...) and returns baked quads, some of which have set their vertex light-map values to full-bright and set their isShade() and hasAmbientOcclusion() values to false.

On NeoForge, without Sodium, these quads are clearly visible as emissive. However, when Sodium is installed, these quads suddenly appear much darker, due to the effects of diffuse lighting and ambient occlusion.

Without Sodium installed:

With Sodium Installed:

Note: I also tried emitting the same quads using the Fabric Render API instead of NeoForge's BakedQuad-based API and the FRAPI quads were lit properly. Only the NeoForge BakedQuad quads were improperly lit.

Reproduction Steps

Create a mod for NeoForge mod that implements IBakedModelExtension.getQuads() and returns a BakedQuad that has its light-map values set to full-brightness and its isShade() and hasAmbientOcclusion() values set to false.
Test the mod without Sodium and observe the brightness of the quad.
Test the mod with Sodium and observe that the quad now has diffuse lighting and ambient occlusion effects.

I have a repository that can be used to demonstrate the issue: Kneelawk/KRender@e7c001b. The issue is demonstrated using the example mod ct_complicated under the examples directory. Note that compiled libs will appear under build/libs under the root directory of the repository, not under the example's own build directory.