Texture Bleeding with Custom Models using half pixel translations

Question

Texture Bleeding with Custom Models using half pixel translations

MrKinau opened this issue 2 months ago · 9 comments

MrKinau commented 2 months ago

Bug Description

When using a resource pack with models using a custom texture translation, which moves the model by half a pixel, it will result in texture bleeding at the edges.

Reproduction Steps

Steps apply for 1.21.4 only:

Install this example resource pack: test.zip
Select GUI Scale 3
Give yourself the test item /give @s paper[minecraft:item_model="test:test"]
Observe the item has a orange stripe at the left (texture bleeding)

Additional Info:
The resource pack is designed to demonstrate this issue with the following test model:

{
  "parent": "minecraft:item/generated",
  "textures": {
    "layer0": "test:custom/test"
  },
  "display": {
    "gui": {
      "translation": [0.5, -0.5, 0]
     }
   }
}

Unfortunately the texture bleeding is not visible without changing an additional texture. In my case the atlas generated like this:

I changed the texture of weeping vines to plain orange and the texture bleeding is visible like seen in the image above.

Log File

[20:01:14] [main/INFO]: Loading Minecraft 1.21.4 with Fabric Loader 0.16.9
[20:01:14] [main/INFO]: Loading 11 mods:
- fabricloader 0.16.9
-- mixinextras 0.4.1
- java 21
- minecraft 1.21.4
- sodium 0.6.6+mc1.21.4
|-- fabric-api-base 0.4.54+b47eab6b04
|-- fabric-block-view-api-v2 1.0.19+7feeb73304
|-- fabric-renderer-api-v1 5.0.2+84404cdd04
|-- fabric-rendering-data-attachment-v1 0.3.57+73761d2e04
|-- fabric-rendering-fluids-v1 3.1.19+7feeb73304
-- fabric-resource-loader-v0 3.0.11+b1caf1e904
[20:01:14] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.7 Source=file:/home/david/.local/share/PrismLauncher/libraries/net/fabricmc/sponge-mixin/0.15.4+mixin.0.8.7/sponge-mixin-0.15.4+mixin.0.8.7.jar Service=Knot/Fabric Env=CLIENT
[20:01:14] [main/INFO]: Compatibility level set to JAVA_21
[20:01:14] [main/INFO]: Loaded configuration file for Sodium: 43 options available, 0 override(s) found
[20:01:14] [main/INFO]: Searching for graphics cards...
[20:01:14] [main/INFO]: Found graphics adapter: LinuxPciAdapterInfo[vendor=NVIDIA, name=GP104 [GeForce GTX 1080], pciVendorId=0x10de, pciDeviceId=0x1b80]
[20:01:14] [main/WARN]: Sodium has applied one or more workarounds to prevent crashes or other issues on your system: [NVIDIA_THREADED_OPTIMIZATIONS_BROKEN]
[20:01:14] [main/WARN]: This is not necessarily an issue, but it may result in certain features or optimizations being disabled. You can sometimes fix these issues by upgrading your graphics driver.
[20:01:15] [Datafixer Bootstrap/INFO]: 243 Datafixer optimizations took 90 milliseconds
[20:01:15] [main/INFO]: Initializing MixinExtras via com.llamalad7.mixinextras.service.MixinExtrasServiceImpl(version=0.4.1).
[20:01:17] [Render thread/INFO]: Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD]
[20:01:17] [Render thread/INFO]: Setting user: MrKinau
[20:01:17] [Render thread/INFO]: Backend library: LWJGL version 3.3.3-snapshot
[20:01:17] [Render thread/INFO]: Modifying process environment to apply workarounds for the NVIDIA graphics driver...
[20:01:17] [Render thread/INFO]: OpenGL Vendor: NVIDIA Corporation
[20:01:17] [Render thread/INFO]: OpenGL Renderer: NVIDIA GeForce GTX 1080/PCIe/SSE2
[20:01:17] [Render thread/INFO]: OpenGL Version: 3.2.0 NVIDIA 535.183.01
[20:01:17] [Render thread/INFO]: Modifying OpenGL context to apply workarounds for the NVIDIA graphics driver...
[20:01:17] [Render thread/INFO]: Reloading ResourceManager: vanilla, fabric, fabric-api-base, fabric-block-view-api-v2, fabric-renderer-api-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-resource-loader-v0, fabricloader, sodium, file/test.zip
[20:01:18] [Worker-Main-16/INFO]: Found unifont_jp_patch-16.0.01.hex, loading
[20:01:18] [Worker-Main-7/INFO]: Found unifont_all_no_pua-16.0.01.hex, loading
[20:01:18] [Render thread/INFO]: OpenAL initialized on device Built-in Audio Analog Stereo
[20:01:18] [Render thread/INFO]: Sound engine started
[20:01:18] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas
[20:01:18] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas
[20:01:18] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[20:01:18] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[20:01:18] [Render thread/INFO]: Created: 2048x1024x4 minecraft:textures/atlas/armor_trims.png-atlas
[20:01:18] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas
[20:01:18] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[20:01:18] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[20:01:18] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[20:01:18] [Render thread/INFO]: Created: 64x64x0 minecraft:textures/atlas/map_decorations.png-atlas
[20:01:18] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/particles.png-atlas
[20:01:18] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/paintings.png-atlas
[20:01:18] [Render thread/INFO]: Created: 256x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[20:01:18] [Render thread/INFO]: Created: 1024x512x0 minecraft:textures/atlas/gui.png-atlas
[20:01:24] [Render thread/INFO]: Loaded 1370 recipes
[20:01:24] [Render thread/INFO]: Loaded 1481 advancements
[20:01:25] [Server thread/INFO]: Starting integrated minecraft server version 1.21.4
[20:01:25] [Server thread/INFO]: Generating keypair
[20:01:25] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[20:01:25] [Render thread/INFO]: Preparing spawn area: 0%
[20:01:25] [Render thread/INFO]: Time elapsed: 380 ms
[20:01:25] [Server thread/INFO]: Changing view distance to 18, from 10
[20:01:25] [Server thread/INFO]: Changing simulation distance to 8, from 0
[20:01:26] [Server thread/INFO]: MrKinau[local:E:548f667a] logged in with entity id 17 at (-752.9223899205344, 78.0, -762.6085904103562)
[20:01:26] [Server thread/INFO]: MrKinau joined the game
[20:01:26] [Render thread/INFO]: Started 10 worker threads
[20:01:26] [Render thread/INFO]: Loaded 6 advancements
[20:01:27] [Server thread/INFO]: Saving and pausing game...
[20:01:27] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[20:01:27] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[20:01:27] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[20:01:31] [Server thread/INFO]: Saving and pausing game...
[20:01:31] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[20:01:31] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[20:01:31] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[20:01:34] [Render thread/INFO]: Reloading ResourceManager: vanilla, fabric, fabric-api-base, fabric-block-view-api-v2, fabric-renderer-api-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-resource-loader-v0, fabricloader, sodium, file/test.zip
[20:01:34] [Worker-Main-23/INFO]: Found unifont_jp_patch-16.0.01.hex, loading
[20:01:34] [Worker-Main-17/INFO]: Found unifont_all_no_pua-16.0.01.hex, loading
[20:01:35] [Render thread/INFO]: OpenAL initialized on device Built-in Audio Analog Stereo
[20:01:35] [Render thread/INFO]: Sound engine started
[20:01:35] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas
[20:01:35] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas
[20:01:35] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[20:01:35] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[20:01:35] [Render thread/INFO]: Created: 2048x1024x4 minecraft:textures/atlas/armor_trims.png-atlas
[20:01:35] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas
[20:01:35] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[20:01:35] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[20:01:35] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[20:01:35] [Render thread/INFO]: Created: 64x64x0 minecraft:textures/atlas/map_decorations.png-atlas
[20:01:35] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/particles.png-atlas
[20:01:35] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/paintings.png-atlas
[20:01:35] [Render thread/INFO]: Created: 256x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[20:01:35] [Render thread/INFO]: Created: 1024x512x0 minecraft:textures/atlas/gui.png-atlas
[20:01:35] [Render thread/INFO]: Stopping worker threads
[20:01:35] [Render thread/INFO]: Started 10 worker threads
[20:01:39] [Server thread/INFO]: Saving and pausing game...
[20:01:39] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[20:01:39] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[20:01:39] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[20:01:39] [Server thread/INFO]: MrKinau lost connection: Disconnected
[20:01:39] [Server thread/INFO]: MrKinau left the game
[20:01:39] [Server thread/INFO]: Stopping singleplayer server as player logged out
[20:01:39] [Server thread/INFO]: Stopping server
[20:01:39] [Server thread/INFO]: Saving players
[20:01:39] [Server thread/INFO]: Saving worlds
[20:01:39] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[20:01:39] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[20:01:39] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[20:01:39] [Server thread/INFO]: ThreadedAnvilChunkStorage (New World (1)): All chunks are saved
[20:01:39] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[20:01:39] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[20:01:39] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[20:01:39] [Render thread/INFO]: Stopping worker threads
[20:01:40] [Render thread/INFO]: Stopping!

Crash Report

---- Minecraft Crash Report ----
// Ouch. That hurt :(

Time: 2025-02-09 20:03:36
Description: Manually triggered debug crash

java.lang.Throwable: Manually triggered debug crash
at knot//net.minecraft.class_309.method_1474(class_309.java:556)
at knot//net.minecraft.class_310.method_1574(class_310.java:1937)
at knot//net.minecraft.class_310.method_1523(class_310.java:1302)
at knot//net.minecraft.class_310.method_1514(class_310.java:922)
at knot//net.minecraft.client.main.Main.main(Main.java:267)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Render thread
Stacktrace:
at knot//net.minecraft.class_309.method_1474(class_309.java:556)

-- Manual crash details --
Details:
Modules:
Stacktrace:
at knot//net.minecraft.class_309.method_1474(class_309.java:556)
at knot//net.minecraft.class_310.method_1574(class_310.java:1937)
at knot//net.minecraft.class_310.method_1523(class_310.java:1302)
at knot//net.minecraft.class_310.method_1514(class_310.java:922)
at knot//net.minecraft.client.main.Main.main(Main.java:267)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

-- Uptime --
Details:
JVM uptime: 24.386s
Wall uptime: 21.715s
High-res time: 21.553s
Client ticks: 417 ticks / 20.850s
Stacktrace:
at knot//net.minecraft.class_310.method_1587(class_310.java:2371)
at knot//net.minecraft.class_310.method_54580(class_310.java:991)
at knot//net.minecraft.class_310.method_1514(class_310.java:943)
at knot//net.minecraft.client.main.Main.main(Main.java:267)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

-- Affected level --
Details:
All players: 1 total; [class_746['MrKinau'/17, l='ClientLevel', x=-752.92, y=78.00, z=-762.61]]
Chunk stats: 1849, 1301
Level dimension: minecraft:overworld
Level spawn location: World: (-560,68,-256), Section: (at 0,4,0 in -35,4,-16; chunk contains blocks -560,-64,-256 to -545,319,-241), Region: (-2,-1; contains chunks -64,-32 to -33,-1, blocks -1024,-64,-512 to -513,319,-1)
Level time: 462585 game time, 6090 day time
Server brand: fabric
Server type: Integrated singleplayer server
Tracked entity count: 175

-- Last reload --
Details:
Reload number: 1
Reload reason: initial
Finished: Yes
Packs: vanilla, fabric, fabric-api-base, fabric-block-view-api-v2, fabric-renderer-api-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-resource-loader-v0, fabricloader, sodium, file/test.zip

-- System Details --
Details:
Minecraft Version: 1.21.4
Minecraft Version ID: 1.21.4
Operating System: Linux (amd64) version 6.8.0-45-generic
Java Version: 21.0.4, Ubuntu
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Ubuntu
Memory: 332929184 bytes (317 MiB) / 1308622848 bytes (1248 MiB) up to 6291456000 bytes (6000 MiB)
CPUs: 28
Processor Vendor: GenuineIntel
Processor Name: Intel(R) Core(TM) i7-14700KF
Identifier: Intel64 Family 6 Model 183 Stepping 1
Microarchitecture: Raptor Lake
Frequency (GHz): 5.50
Number of physical packages: 1
Number of physical CPUs: 20
Number of logical CPUs: 28
Graphics card #0 name: GP104 [GeForce GTX 1080]
Graphics card #0 vendor: NVIDIA Corporation (0x10de)
Graphics card #0 VRAM (MiB): 288.00
Graphics card #0 deviceId: 0x1b80
Graphics card #0 versionInfo: unknown
Virtual memory max (MiB): 40196.61
Virtual memory used (MiB): 15944.72
Swap memory total (MiB): 8192.00
Swap memory used (MiB): 0.00
Space in storage for jna.tmpdir (MiB):
Space in storage for org.lwjgl.system.SharedLibraryExtractPath (MiB):
Space in storage for io.netty.native.workdir (MiB):
Space in storage for java.io.tmpdir (MiB): available: 31966.76, total: 32004.62
Space in storage for workdir (MiB): available: 918854.25, total: 1907424.63
JVM Flags: 20 total; -XX:+UseG1GC -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=200 -XX:+UnlockExperimentalVMOptions -XX:+DisableExplicitGC -XX:+AlwaysPreTouch -XX:G1HeapWastePercent=5 -XX:G1MixedGCCountTarget=4 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=5 -XX:SurvivorRatio=32 -XX:+PerfDisableSharedMem -XX:MaxTenuringThreshold=1 -XX:G1NewSizePercent=30 -XX:G1MaxNewSizePercent=40 -XX:G1HeapRegionSize=8M -XX:G1ReservePercent=20 -XX:InitiatingHeapOccupancyPercent=15 -Xms512m -Xmx6000m
Launched Version: 1.21.4
Launcher name: PrismLauncher
Backend library: LWJGL version 3.3.3-snapshot
Backend API: NVIDIA GeForce GTX 1080/PCIe/SSE2 GL version 3.2.0 NVIDIA 535.183.01, NVIDIA Corporation
Window size: 1920x1016
GFLW Platform: x11
GL Caps: Using framebuffer using OpenGL 3.2
GL debug messages:
Is Modded: Definitely; Client brand changed to 'fabric'; Server brand changed to 'fabric'
Universe: 400921fb54442d18
Type: Integrated Server (map_client.txt)
Graphics mode: fabulous
Render Distance: 18/18 chunks
Resource Packs: vanilla, fabric, fabric-api-base, fabric-block-view-api-v2, fabric-renderer-api-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-resource-loader-v0, fabricloader, sodium, file/test.zip
Current Language: en_us
Locale: en_US
System encoding: UTF-8
File encoding: UTF-8
CPU: 28x Intel(R) Core(TM) i7-14700KF
Server Running: true
Player Count: 1 / 8; [class_3222['MrKinau'/17, l='ServerLevel[New World]', x=-752.92, y=78.00, z=-762.61]]
Active Data Packs: vanilla, fabric, file/cxn-datapack.zip (incompatible)
Available Data Packs: fabric, file/cxn-datapack.zip (incompatible), minecart_improvements, redstone_experiments, trade_rebalance, vanilla
Enabled Feature Flags: minecraft:vanilla
World Generation: Experimental
World Seed: 420884075451684717
Suppressed Exceptions: ~~NONE~~

MrKinau · Answer 1 · 2025-02-15T04:08:26.000Z

Oh actually one thing that may help pretty much: I play on GUI scale 3, it seems to only happen on GUI scale 3 for me

jellysquid3 · Answer 2 · 2025-02-15T03:52:16.000Z

I can't reproduce the issue as described. The interfering texture is on the left edge of the item's texture, like so:

But in game, it renders correctly:

MrKinau · Answer 3 · 2025-02-15T04:04:19.000Z

Hmm that's odd. I've only tested on two devices with two different GPUs and OS, but was able to reproduce it on both consistently 🤔

Let me know if there is anything else I can give you to help investigating the issue. Here is the atlas:

atlas.zip

jellysquid3 · Answer 4 · 2025-02-15T03:59:33.000Z

This may be related to #2582...

Can you dump the texture atlases with F3+S and then upload them as a ZIP file in a comment?

jellysquid3 · Answer 5 · 2025-02-15T22:22:07.000Z

I've looked at the files you provided and compared it to what my client is generating, and see no differences. So I can't hypothesize a reason this is happening, because this doesn't fit the criteria for a driver-specific bug.

MrKinau · Answer 6 · 2025-02-16T21:33:57.000Z

I've tested with 3 friends of mine. All were able to reproduce on GUI scale 3, can you try reproducing it again?

MrKinau · Answer 7 · 2025-02-25T22:47:25.000Z

but am not any closer to understanding why it is happening

It must've been a "more recent" issue as I did not notice it in previous versions. I've just tested which version introduced it and discovered that this issue was not present in sodium 1.21-0.5.11, but is present in sodium 1.21-0.6.0-beta.1-fabric (and I assume every following version). Both versions tested within 1.21 and 1.21.1

MrKinau · Answer 8 · 2025-02-26T00:14:00.000Z

I've just tested every commit individually and could track it down to this commit

After removing the FaceBakeryMixin or in recent versions TextureAtlasSpriteMixin I can't reproduce this issue anymore. Actually I have no clue onto what this mixin is for or how to fix this properly, but hopefully me tracking it down helps understanding it a little :)

jellysquid3 · Answer 9 · 2025-02-19T20:02:54.000Z

After talking to others we were able to figure out that it depends on the location of the item in the inventory, and doesn't appear at every scale factor. I can reproduce the issue now, but am not any closer to understanding why it is happening.

Share to

Bug Description

Reproduction Steps

Log File

Crash Report

A detailed walkthrough of the error, its code path and all known details is as follows: