"Use Fog Occlusion" messes with Foggy Pale Garden's fog system
BugmanBugman opened this issue · 2 comments
Bug Description
If you have the "Performance - Use Fog Occlusion" setting enabled while also having Foggy Pale Garden installed (which adds custom fog to said biome), the blocks behind the fog do not continue to render and appear suddenly when the player approaches. This has been noted as such on the mod page. Here's a photo comparison by the mod author.
For a more direct comparison, here's how the game looks with sodium and FBP, but fog occlusion is disabled
Now here's with it enabled.
Notice how blocks don't render, and you can see farther than you're intended?
Reproduction Steps
- Install both Sodium and FBP
- Go to pale garden, note FBP's fog effect
- enable fog occlusion option on and off and notice how rendering is messed up
Log File
Crash Report
This problem happens because the fog color is different from the skybox, which causes a discontinuity. If they were the same color, the blocks would fade into the background, and the effect would work correctly.
Unfortunately, there is not really a way to solve this. Using the fog parameters to limit the render distance has a significant performance improvement (especially in the Nether) but it does sometimes cause issues, hence why we provide the option.
In an ideal world, Minecraft's fog effect would sample the color of the skybox, which would avoid the discontinuity and fix most issues (with some exceptions, see #2634). However, this would require Sodium to change the terrain shader and skybox shader significantly, which we currently do not.
It's worth mentioning that you'll see the same problem if the user decreases their render distance significantly, which is essentially what Sodium is doing when it detects this very dense fog.
Maybe Sodium should just enforce a "minimum" render distance (maybe 50% of the user's configured render distance) regardless of how dense the fog is. This won't be perfect, but it might look good enough.