Smooth Lighting has jagged edges in some directions.
TwistedZero opened this issue · 8 comments
Expected Behavior
The light is smooth in all directions.
Actual Behavior
The light is smooth in two parallel directions but jagged in the other two.
Reproduction Steps
- Smooth Lighting should be set to Low/High and Brightness should be set to 100 for best visibility.
- Create a Superflat world with the following preset:
minecraft:bedrock,4*minecraft:white_concrete,4*minecraft:air,4*minecraft:white_concrete;minecraft:desert - Break a hole in the ceiling so that light will shine into the layer of air.
- Observe that the edge of the light is jagged in some directions.
Attachments
System Information
- Java Version: 1.8.0_222 (64-bit OpenJDK Hotspot)
- CPU: Ryzen 5 2500u
- GPU: Vega 8 Integrated Graphics
Can replicate with gradlew runClient on tag 0.3.2 (thus no other mods).
The orientation of the defect is 135 degrees; 45 degrees edges are correctly averaged.
I managed to reproduce it with Sodium 0.4.10, it's just harder to reproduce it with Sodium 0.4.10.
It looks like this issue might be caused by using an older version of Sodium. I am unable to reproduce it with the latest version:
I still see this issue with both a self built version on the latest commit and release candidate 7 from Discord.
My self built version was compiled with Java 8 and tested on both Java 8 and Java 14 while release candidate 7 was only tested with Java 14, the issue was visible in all cases.
This issue is most visible when there is no sky light, note how there is no blue tint to the white concrete in this image:
It also happens on walls:
I have noticed that the light is being smoothed correctly until it gets to the edge (where both sky and block light are 0).
I have tested release 0.1 and this issue is still present, so I have put together a test world to help reproduce it:
When you enter this world you should see two large rooms, one showing the issue using sky light, the other showing it using block light.
I will update this comment to mention the latest version I have tested that still has this issue.
