Some Assembly Required

Some Assembly Required

Mods
2M Downloads

[1.18.1] Crash when Diet tries to render nutrition tooltips on Sandwiches with any Potion added

Prunoideae opened this issue ยท 1 comments

commented

Crash report:
crash-2022-03-12_13.19.18-client.txt

starts at

some-assembly-required/src/main/java/someassemblyrequired/integration/diet/DietCompat.java

Line 34 in fd08836

new ImmutableTriple<>(handler.getItems(), handler.getTotalNutrition(), handler.getAverageSaturation())

where

some-assembly-required/src/main/java/someassemblyrequired/common/item/sandwich/SandwichItemHandler.java

Lines 67 to 73 in fd08836

public int getTotalNutrition() {
int result = 0;
for (ItemStack stack : items) {
result += Ingredients.getFood(stack).getNutrition();
}
return result;
}

but

some-assembly-required/src/main/java/someassemblyrequired/common/ingredient/Ingredients.java

Lines 51 to 53 in fd08836

public static FoodProperties getFood(ItemStack item) {
return IngredientPropertiesManager.getOrDefault(item).getFood(item);
}

some-assembly-required/src/main/java/someassemblyrequired/common/ingredient/PotionProperties.java

Lines 27 to 29 in fd08836

public FoodProperties getFood(ItemStack item) {
return null;
}

commented

Thanks for the detailed report! Diet didn't have a release for 1.18 yet when I implemented compatibility, that's why I forgot to properly test it. I've uploaded a patch that fixes the issue. (It seems there's some issues with curseforge at the moment though, it might take some time to be approved)