Soot

Soot

7M Downloads

[Bug] Melter Removal by Input Not Working

Opened this issue ยท 8 comments

commented

Minecraft Version: 1.12.2
Forge Build: 2611
Mod Version: 0.5

Sample script:
#modloaded embers
#modloaded soot
import mods.embers.Melter;
Melter.remove(<embers:plate_gold>);

This script does not throw an error, but it fails to remove the Melter recipe for a gold plate into molten gold.

commented

Oh wait, github killed the formatting
Didn't I fix this recently what the hell is it with this goddamn recipe removal

commented

Github has indeed eaten the greater than and less than symbols. I've escaped them to fix it to what it's meant to be.

commented

can i get uhhh minetweaker log

commented

Here's the log for the entire Embers script I've written; https://pastebin.com/KzKRQCe4

commented

Hey sorry for taking so long to reply, you can (and have to) use Melter.remove(<ore:plateGold>)

commented

oof i remember that one

commented

In my experience with CT, overloading methods with the same number of parameters doesn't work as expected.

For example:

void remove(IItemStack);
void remove(ILiquidStack);
void remove(IOreDictEntry);

Won't work properly, but renaming to:

void removeByInput(IItemStack);
void removeByOutput(ILiquidStack);
void removeByOreDict(IOreDictEntry);

Should fix the problem.

Edit: Yeah, nvm. I tried that fix and still get: Removing 0 Melter Recipe(s) for Unknown item.

commented

everything should work normally now and also the integration is now moved to Embers itself