Sophisticated Backpacks

Sophisticated Backpacks

89M Downloads

Redundant curio slot check

ochotonida opened this issue ยท 0 comments

commented

Describe the bug
The ICurio implementation for backpacks has a check for the back slot type, preventing it from being equipped in any other slot:

@Override
public boolean canEquip(String identifier, LivingEntity livingEntity) {
return identifier.equals(SlotTypePreset.BACK.getIdentifier());
}

Curios already checks whether a curio has the corresponding tag for a slot, which makes this check redundant.
Additionally, since this check is hard-coded to the back slot type, it is no longer possible to change the slot type of backpacks using a datapack, neither is it possible to equip backpacks in a curio slot, which accepts any curio.

To Reproduce
See linked code

Versions
Any