Exploit / Bug: Duplicating fluids with Tank Upgrade and Adv. Pump Upgrade
xShadowEagle opened this issue ยท 1 comments
Describe the bug:
It is possible to duplicate fluids with the Tank Upgrade and the Advanced Pump Upgrade using any backpack which can hold these upgrades. To start duplicating, a single bucket of fluid is enough.
To Reproduce:
Steps to reproduce the behavior:
- Add the Tank Upgrade and Advanced Pump Upgrade to a backpack
- Get some fluid in the backpack, any method works, e.g. pumping placed fluids from the world into the backpack by placing the backpack near the fluid source blocks.
- Enable the "Interact with Fluid Container in Hand" option of the Advanced Pump Upgrade
- Place the backpack on any block by sneaking and right-clicking
- By now, the fluid inside the backpack should have doubled
- Pick the backpack up by sneaking and right-clicking
- Repeat steps 4-6 for infinite fluids
Expected behavior:
The fluid inside the backpack should not increase in volume while no fluid in the world or inventory is present.
Guess:
My (un)educated guess is that the backpack itself counts as a held item when being placed down, which would explain the doubling of the fluid. Some form of check should be enough to either exclude the backpack itself from held items or wait for the backpack to be removed from the players inventory before checking held items for fluids.
Versions:
Minecraft version: 1.18.1
Forge version: 1.18.1-39.1.0
Mod version: 1.18.1-3.15.15.550
