Sophisticated Backpacks

Sophisticated Backpacks

Mods
89M Downloads

Compat with Ender Tanks (fluid multiplication issue)

Raidobw2 opened this issue ยท 2 comments

commented

Describe the bug
If you use (right click) an Ender Bucket from EnderTanks https://www.curseforge.com/minecraft/mc-mods/endertanks on the tank bar, it multiplies the fluid quickly and can overflow
image
image

To Reproduce

  1. Fill an Ender Bucket with at least 2 buckets' worth of a fluid
  2. Open a backpack and put the Tank Upgrade into an upgrade slot
  3. Grab the Ender Bucket in the inventory GUI and hover over the tank in the backpack
  4. Right-click on the tank. It should now have 1,000mB worth of fluid in it
  5. Right-click on the tank again. It should now have an amount close to the amount in the Ender Bucket when you started minus 1,000mB.
  6. Keep right-clicking the tank. It will keep filling up with the amount in the previous step and will go beyond the tank limit

Expected behavior
No fluid dupe, or not having the possibility to right click with that Ender Bucket on the tank bar

Screenshots
Right click the Ender Tank against the tank bar to multiply fluids

overflow.mp4

Versions
MC 1.18.2
Forge 40.1.73
Sophisticated Backpacks sophisticatedbackpacks-1.18.2-3.18.17.680.jar
Sophisticated Core sophisticatedcore-1.18.2-0.5.1.98.jar
Ender Tanks endertanks-1.18-1.11.7.jar ( + requires lib dependency)

Relayed from FTBTeam/FTB-Modpack-Issues#1154

Thanks in advance for checking it out!

commented

I made a minor modification on my side, but this is really an issue in ender tanks because when their fill method is called (yes in this case tank upgrade is actually trying to fill the ender bucket) they return negative value of the total amount of fluid in ender bucket. So my modification is to just ignore filled negative values, but this could be causing issues with other mods as well.

commented

Thank you! I'll properly report this to Ender Tanks then, thank you for the information as well