Sophisticated Core

Sophisticated Core

88M Downloads

Player inventory slots are rendered twice if sophisticated inventory doesn't have a scrollbar

radimous opened this issue ยท 5 comments

commented

This makes transculent items much more saturated and slightly hurts performance
tested on 1.18.2 and 1.21.1 and both versions have this issue

1.18.2 with scrollbar is fine
1182-scrollbar_fine
1.18.2 without scrollbar - items are rendered twice
1182-noscroll-bad

1.21.1 with scrollbar is fine
1211-noscroll-bad
1.21.1 without scrollbar - items are rendered twice
1211-scrollbar-good

they are rendered like this
StorageScreenBase#render -> renderSuper -> renderSlot
StorageScreenBase#render -> renderSuper -> renderLabels -> renderStorageInventorySlots -> renderStorageInventorySlots -> renderSlot

commented

I am aware this was the issue and I haven't fixed it in 1.18.2 because I didn't consider it critical enough, but this should be fixed in 1.21. What version have you got there? One of the latest?

commented

Actually I can see it happening in dev so I probably only previously solved this for the storage slots

commented

This is fixed in the latest 1.20 and 1.21 releases. I am not going to fix it in 1.18 as it's not that critical of a bug.

commented

thanks, I am just going to mixin the fix in 1.18

commented

thanks, I am just going to mixin the fix in 1.18

will you make this public please? or PR it to unobtanium? I'm sure wolf wont mind!