Sophisticated Core

Sophisticated Core

88M Downloads

The removal of the function "setChangeListener" in RenderInfo.java breaks compatibility with AE2

zFERDQFREZrzfq opened this issue ยท 3 comments

commented

Hello,

On 1.20.1, the version 1.2.27 and up of Core breaks support with AE2 15.3.4 (latest available at the time of writing) because of the renaming of the setChangeListener function in RenderInfo.java.

Versions :
MC : 1.20.1
Forge : 47.4.0
AE2 : 15.3.4
Sophisticated Core : >= 1.2.27

To reproduce :
Set up a world with AE2 + Sophisticated Storage and hook up a limited barrel to an AE2 network using a Storage Bus.

Crash log :
java.lang.NoSuchMethodError: 'void net.p3pp3rf1y.sophisticatedcore.renderdata.RenderInfo.setChangeListener(java.util.function.Consumer)' at net.p3pp3rf1y.sophisticatedstorage.block.BarrelBlockEntity.<init>(BarrelBlockEntity.java:65) ~[sophisticatedstorage-1.20.1-1.3.9.1075.jar%23749!/:1.20.1-1.3.9.1075] {re:classloading} at net.p3pp3rf1y.sophisticatedstorage.block.LimitedBarrelBlockEntity.<init>(LimitedBarrelBlockEntity.java:45) ~[sophisticatedstorage-1.20.1-1.3.9.1075.jar%23749!/:1.20.1-1.3.9.1075] {re:classloading} at net.p3pp3rf1y.sophisticatedstorage.block.LimitedBarrelBlock.newBlockEntity(LimitedBarrelBlock.java:119) ~[sophisticatedstorage-1.20.1-1.3.9.1075.jar%23749!/:1.20.1-1.3.9.1075] {re:classloading} at net.p3pp3rf1y.sophisticatedstorage.block.LimitedBarrelBlock.m_142194_(LimitedBarrelBlock.java:49) ~[sophisticatedstorage-1.20.1-1.3.9.1075.jar%23749!/:1.20.1-1.3.9.1075] {re:classloading} at net.minecraft.world.level.chunk.LevelChunk.m_62934_(LevelChunk.java:288) ~[client-1.20.1-20230612.114412-srg.jar%23796!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:lithium.mixins.json:world.inline_block_access.WorldChunkMixin,pl:mixin:APP:lithium.mixins.json:collections.block_entity_tickers.WorldChunkMixin,pl:mixin:APP:lithium.mixins.json:world.combined_heightmap_update.WorldChunkMixin,pl:mixin:APP:lithium.mixins.json:world.inline_height.WorldChunkMixin,pl:mixin:APP:flywheel.mixins.json:instancemanage.InstanceAddMixin,pl:mixin:APP:refurbished_furniture.common.mixins.json:LevelChunkMixin,pl:mixin:APP:moonlight-common.mixins.json:LevelChunkMixin,pl:mixin:A} at net.minecraft.world.level.chunk.LevelChunk.m_5685_(LevelChunk.java:315) ~[client-1.20.1-20230612.114412-srg.jar%23796!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:lithium.mixins.json:world.inline_block_access.WorldChunkMixin,pl:mixin:APP:lithium.mixins.json:collections.block_entity_tickers.WorldChunkMixin,pl:mixin:APP:lithium.mixins.json:world.combined_heightmap_update.WorldChunkMixin,pl:mixin:APP:lithium.mixins.json:world.inline_height.WorldChunkMixin,pl:mixin:APP:flywheel.mixins.json:instancemanage.InstanceAddMixin,pl:mixin:APP:refurbished_furniture.common.mixins.json:LevelChunkMixin,pl:mixin:APP:moonlight-common.mixins.json:LevelChunkMixin,pl:mixin:A} at net.minecraft.world.level.Level.m_7702_(Level.java:560) ~[client-1.20.1-20230612.114412-srg.jar%23796!/:?] {re:computing_frames,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:botania_xplat.mixins.json:LevelAccessor,pl:mixin:APP:lithium.mixins.json:alloc.chunk_random.WorldMixin,pl:mixin:APP:lithium.mixins.json:entity.collisions.intersection.WorldMixin,pl:mixin:APP:lithium.mixins.json:util.block_entity_retrieval.WorldMixin,pl:mixin:APP:lithium.mixins.json:util.block_tracking.block_listening.WorldMixin,pl:mixin:APP:lithium.mixins.json:world.chunk_access.WorldMixin,pl:mixin:APP:lithium.mixins.json:world.inline_block_access.WorldMixin,pl:mixin:APP:lithium.mixins.json:world.inline_height.WorldMixin,pl:mixin:APP:citadel.mixins.json:LevelMixin,pl:mixin:APP:refurbished_furniture.common.mixins.json:LevelMixin,pl:mixin:A} at appeng.api.networking.GridHelper.getNodeHost(GridHelper.java:133) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.api.networking.GridHelper.getExposedNode(GridHelper.java:151) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.me.InWorldGridNode.findInWorldConnections(InWorldGridNode.java:64) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.me.GridNode.updateState(GridNode.java:251) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.me.GridNode.markReady(GridNode.java:386) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.me.ManagedGridNode.createNode(ManagedGridNode.java:171) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.me.ManagedGridNode.create(ManagedGridNode.java:157) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.blockentity.grid.AENetworkPowerBlockEntity.onReady(AENetworkPowerBlockEntity.java:96) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.blockentity.networking.ControllerBlockEntity.onReady(ControllerBlockEntity.java:66) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.hooks.ticking.ServerBlockEntityRepo$FirstTickInfo.callInit(ServerBlockEntityRepo.java:43) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.hooks.ticking.TickHandler.readyBlockEntities(TickHandler.java:408) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.hooks.ticking.TickHandler.onServerLevelTickEnd(TickHandler.java:277) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at appeng.hooks.ticking.TickHandler.onLevelTick(TickHandler.java:248) ~[appliedenergistics2-forge-15.3.4.jar%23484!/:?] {re:classloading} at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) ~[eventbus-6.0.5.jar%23137!/:?] {} at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) ~[eventbus-6.0.5.jar%23137!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%23137!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%23137!/:?] {} at net.minecraftforge.event.ForgeEventFactory.onPostLevelTick(ForgeEventFactory.java:955) ~[forge-1.20.1-47.4.0-universal.jar%23801!/:?] {re:mixin,re:classloading,pl:mixin:A} at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:899) ~[client-1.20.1-20230612.114412-srg.jar%23796!/:?]

commented

You need to update sophisticated storage when you update core otherwise stuff like this can happen. Just do that and you're good

commented

Oh ok, I had to disable auto-update of Storage because 3.10 and up breaks compat with Create below 6, and I can't update Create yet because Steam&Rails didn't updated yet (and hidden the WIP branch for some reason)...

commented

Oh ok, I had to disable auto-update of Storage because 3.10 and up breaks compat with Create below 6, and I can't update Create yet because Steam&Rails didn't updated yet (and hidden the WIP branch for some reason)...

it would be very odd that storage alone would break compatiblity with create because it doesn't have dependency on create / doesn't directly implement anything for create, only indirectly has some supporting stuff for what is then used in separate Create Integration mod. It's actually sophisticated core that has dependency on create 0.6+