Crash LimitedBarrelScreen UI
Closed this issue · 19 comments
This crash when I clicked on UI upgrades slots:
How did you manage to get that nugget in that slot? Just to be sure I have just tested with the latest 1.20 version and I am unable to put anything but storage upgrade in there.
I can't put anything on that slot the problems seams related to upgrading the mod. Basically I was using a older version and updated to the newest one and messed up with the chests.
Older versions before the update:
I just tried with that old version and couldn't get the nugget into upgrade slot, tried upgrading still no issue and still can't get the nugget in there. So it seems to me like some other mod you have there had an interaction that allowed the nugget getting in the slot and that is now causing you these issues. You can break the barrel and set it up again to fix it, but if that other mod allows you to put the nugget in the slot with plain click or shift click this will come back. Could you just confirm this happened just to this single barrel and you are not seeing it anywhere else?
It was multiple.
But for some reason not consistently
Like I have another limited iron barrel 2 with iron nuggets and ingots, and it took the nugget out of the config but not put it on the side. For some reason it was just the limited gold barrel 2 that I had.
Alot more people reporting the same problem after the update also the fill bar is always 100%, but looks more a visual bug.
All up-to-date using create v0.5
Do you have any ideias why this is happening or should I downgrade the mod?
The fill bar I can imagine may need an update to be recalculated, I made a change there and not all cases may get an update immediately especially if you have updated from that old version.
But that crash is the same one as the original and I would need to understand steps how I can recreate because I can't even when using those same exact versions and setup that seems to be the exact same.
The only thought I have on why this is happening to you is that the server had some issue saving / loading and because of that the data got corrupted and incorrect item ended in that upgrade slot or there was some difference in configs between server and client which allowed the gui to insert incorrect item in there (though this one is much less likely because it should just use the number of slots that the actual barrel syncs to client)
actually the fill level showing 0 is a bug on my side in how data are displayed on client - it's still calculated and correct, but clientside 0 is always passed to gui instead of the actual value.
the fill percentages are fixed in the releases(1.20.1 and 1.21.1) that are just about to be uploaded on curseforge/modrinth
The fill got fixed in the new version but the crash still happen.
what is happening is that the filtering option from the compacting upgrade
is going to the upgrade slots of the barrel
the 3 slots had stuff in it, one gold stack upgrade and a void upgrade
it deleted both and placed the nugget there
dont know if it happens with any other filtered upgrades, dont have any set up in my map
Also my community found out downgrading sophisticated storage to 1.20.1-1.3.22.1104 fixed both problems so much be something you have changed in between this updates.
I am still unable to recreate nor find any issue in between the code changes. Also the kind of issue with nugget being in that slot can really only happen when the gui is open and something in code puts it there and I don't see anything at all in my code that could be doing that. So I am strongly starting to suspect something in your pack is messing up with slots here.
One other possibility is that there's some issue with configs. Could you check if sophisticatedstorage-server.toml in [server.GoldBarrel] section has the same number of upgradeSlotCount on both client and server? It shouldn't really matter if it didn't because the gui should be taking this info from the barrel's data that's synced from server, but if it's missing for some reason it would default to what's in the config
As much as I'd like to help, this issue goes beyond what I’m able to debug effectively. I’ve tried multiple times to reproduce it but haven’t been successful. Based on feedback from my community, it seems to only occur with gold Limited Barrels that have a Compacting Upgrade and contain items.
These types of problems are especially tricky to catch, as everything works fine in a fresh install. I've noticed that the server.toml gold stuff has a slot count of 3, and it appears server.toml be recreated when switching mod versions, likely due to config mismatches.
I also tried digging through the changelogs to see what might have changed, but I couldn’t pinpoint anything specific. It looks like the mod gets updated almost daily, which makes it difficult to track individual changes. For now, I’ll be sticking to an older version with more downloads, just for the sake of stability.
Still, I want to sincerely thank you for your quick responses and your effort to help — it’s much appreciated!
understood, I tried recreating wtih the exact same setup as you described in that last screenshot (and of course switched between the versions) and still wasn't able to so there's more going on in that case. If you happen to find out more or happen to figure out steps to recreate please let me know. I will leave this open for a few weeks in case something comes up from your group or someone else.
one more question on this if you don't mind - did you use any regular barrels / chests in your world and have you noticed any of the similar issues with them after the update?
So I got a similar kind of report about disappearing upgrade slots in this case for 1.21 and have applied that same fix in 1.20 as well. if you get a chance and wouldn't mind trying it out new release is up on curseforge / modrinth with the fix and I am hoping it fixes your issue as well because it appears that in your case server loaded only 1 upgrade slot server side (because of an issue in the past that saved just 1 as number of slots for that limited barrel) and client thought there were supposed to be 3 slots there which made it mess up with that nugget getting in the upgrade slot.
The issue with just 1 upgrade slot being loaded is fixed in that latest release.