Sophisticated Storage barrel recipes causes deadlock with Refined Storage patterns
raoulvdberge opened this issue · 2 comments
Hello there,
Check following watchdog deadlock thread dump:
"Server thread" prio=4 Id=196 TIMED_WAITING on java.lang.String@3b53b402
at [email protected]/jdk.internal.misc.Unsafe.park(Native Method)
- waiting on java.lang.String@3b53b402
at [email protected]/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:269)
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.waitForTasks(BlockableEventLoop.java:521)
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:133)
at TRANSFORMER/[email protected]/net.minecraft.server.level.ServerChunkCache$MainThreadExecutor.managedBlock(ServerChunkCache.java:533)
at TRANSFORMER/[email protected]/net.minecraft.server.level.ServerChunkCache.getChunk(ServerChunkCache.java:159)
at TRANSFORMER/[email protected]/net.minecraft.world.level.Level.getChunk(Level.java:202)
at TRANSFORMER/[email protected]/net.minecraft.world.level.LevelReader.getChunk(LevelReader.java:130)
at TRANSFORMER/[email protected]/net.minecraft.world.level.Level.getChunk(Level.java:196)
at TRANSFORMER/[email protected]/net.minecraft.world.level.Level.getChunkAt(Level.java:192)
at TRANSFORMER/[email protected]/net.minecraft.world.level.Level.getBlockEntity(Level.java:771)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.networking.CableBlock.getShape(CableBlock.java:117)
at TRANSFORMER/[email protected]/net.minecraft.world.level.block.state.BlockBehaviour$BlockStateBase.getShape(MixinBlockStateBase.java:648)
at TRANSFORMER/[email protected]/net.minecraft.world.level.block.state.BlockBehaviour$BlockStateBase.getShape(MixinBlockStateBase.java:644)
at TRANSFORMER/[email protected]/net.p3pp3rf1y.sophisticatedstorage.crafting.BarrelMaterialRecipe.matches(BarrelMaterialRecipe.java:55)
at TRANSFORMER/[email protected]/net.p3pp3rf1y.sophisticatedstorage.crafting.BarrelMaterialRecipe.matches(BarrelMaterialRecipe.java:25)
at TRANSFORMER/[email protected]/net.minecraft.world.item.crafting.RecipeManager.lambda$getRecipeFor$2(RecipeManager.java:102)
at TRANSFORMER/[email protected]/net.minecraft.world.item.crafting.RecipeManager$$Lambda/0x000000080896bef0.test(Unknown Source)
at [email protected]/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178)
at [email protected]/java.util.Spliterators$ArraySpliterator.tryAdvance(Spliterators.java:1034)
at [email protected]/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
at [email protected]/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at [email protected]/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at [email protected]/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:647)
at TRANSFORMER/[email protected]/net.minecraft.world.item.crafting.RecipeManager.getRecipeFor(RecipeManager.java:102)
at TRANSFORMER/[email protected]/net.minecraft.world.item.crafting.RecipeManager.getRecipeFor(RecipeManager.java:84)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.autocrafting.PatternItem.getCraftingPattern(PatternItem.java:182)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.autocrafting.PatternItem.getCraftingPattern(PatternItem.java:174)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.autocrafting.PatternItem.getPattern(PatternItem.java:162)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.RefinedStorageApiImpl.lambda$getPattern$4(RefinedStorageApiImpl.java:576)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.RefinedStorageApiImpl$$Lambda/0x0000000808970420.apply(Unknown Source)
at [email protected]/java.util.HashMap.computeIfAbsent(HashMap.java:1228)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.RefinedStorageApiImpl.getPattern(RefinedStorageApiImpl.java:574)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.api.RefinedStorageApiProxy.getPattern(RefinedStorageApiProxy.java:385)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.autocrafting.autocrafter.AutocrafterBlockEntity.patternChanged(AutocrafterBlockEntity.java:311)
at TRANSFORMER/[email protected]/com.refinedmods.refinedstorage.common.autocrafting.autocrafter.AutocrafterBlockEntity.setLevel(AutocrafterBlockEntity.java:302)
- Refined Storage loads the recipes in a crafting pattern as soon as the level is available (the level is still loading at this point)
- The
BarrelMaterialRecipecallsBlock#getShapeon a Refined Storage cable block - The Refined Storage cable blocks calls
Level#getBlockEntity - Deadlock.
I don't think it's a good idea to call an actual level when loading a recipe, because if you do, it can cause a deadlock like this one.
Suggestion: use a fake level instead.
This is fixed in the latest releases for 1.20 and 1.21. And yeah I just used EmptyBlockGetter which is what vanilla uses for some other shape related calls.
You can find the full player report here: https://mclo.gs/ur6m5Dx#L8599