Sophisticated Storage

Sophisticated Storage

36M Downloads

A bug about infinity upgrade

zys7830602 opened this issue · 11 comments

commented

I found a bug that when using infinity upgrade, if there are many types of items in the Barrel, there will be errors when taking them out. For example, when I clicked on a bone with the mouse, I took out a stone. If combined with Tom's simple storage, when viewed in the terminal, I will find that many items have changed their names to air (minecraft: air)
Game version: 1.20.1
Sophisticated Core Version: 1.2.7.860
Sophisticated Storage Version: 1.3.5.1068

bug1.zip

commented

Tom's simple storage Version:1.7.0

commented

I will need steps to recreate here because I am unable to. Are you testing this with just Sophisticated and Tom's or you have other mods in the pack as well? If so are you able to recreate without the other mods?

commented

I only used Sophisticated Storage and Tom for storage mods, while the other mods are adventure mods. The specific steps are as follows:

  1. Place multiple Netherite Inot Barrels;
  2. Place an unlimited upgrade in each wooden barrel;
  3. Randomly place some items in each wooden barrel;
    When I retrieve items from these wooden barrels, there will be a situation where I click on item A but retrieve item B;
  4. After step 3, use Tom's inventory connector and crafting terminal to connect all the newly placed wooden barrels;
    When viewing items in the crafting terminal, it may be found that some of the items have changed their names to air, but they return to normal after being taken out
commented

Or maybe I'll just test it with Sophisticated Storage and Tom later

commented

I didn't mean if you only used these mods in the setup but rather if they were the only mods in the modpack because this looks to me like some interaction with another mod so I want to rule it out

commented

yes, they were the only mods in the modpack,
I just reinstalled the game and mod, using only the Forge, Sophisticated series, tom, And then retested:

  1. Randomly place some items in multiple buckets with unlimited upgrades installed
  2. Use Tom's inventory connector to connect all wooden barrels
  3. Bugs when Sophisticated Storage and Tom are used together:
    (1) Opening a wooden barrel with a crafting terminal to manage items will result in the item name being changed to air
    (2) After removing the item from the crafting terminal and putting it back in, the name of the item that was just removed will be replaced with 'air' in the crafting terminal
  4. Sophisticated Storage itself bug: Opening a bucket with unlimited upgrades installed separately (which contains some items), taking out items from the bucket to the player's backpack, then putting the removed items back into the bucket, and using Sophisticated Storage's built-in sorting function to organize the bucket, will result in a bug where items are taken out incorrectly
commented

Image

commented

Sorting was the thing that I was missing to recreate. Infinity upgrade has a cache and it didn't update it when stacks got sorted. This is now fixed in the latest release.

commented

Thanks,I will test it again later

commented

I just updated the sophicatedcore-1.20.1-1.2.9.867 and tested it. When taking out items from an infinitely upgrade barrel and putting them back in the barrel, multiple identical items will appear in the barrel. After sorting, there will still be multiple identical items in the barrel

Image

commented

That is correct behavior, when you try to put the same item back in there's no place for it in the previously existing slot so it gets put into new slot and sorting sorts underlying items that were used so if you put a full stack in that means there's more than can fit into a single slot and thus it doesn't combine the stacks.