Sophisticated Storage

Sophisticated Storage

36M Downloads

Items inserted into storage by CC:Tweaked ignore specified slot

fireblade004 opened this issue ยท 1 comments

commented

Issue: When an item is inserted into a Sophisticated Storage inventory (such as a chest or barrel with multiple slots) by CC:Tweaked, the item will appear in the first slot it can be inserted into (as opposed to the one specified in the command).

Steps to Reproduce:

  1. Place a computer, then place any type of storage to the left and place a Sophisticated Storage to the right. (In my test I used a Sophisticated Storage oak chest on either side)
  2. Place a single item into the storage on the left, making note of which slot it is placed in (in my example, slot 10 or column 1, row 2). Ensure the storage on the right is empty.
  3. Start the computer by right clicking on it.
  4. At the prompt, run the lua command to open an interactive Lua shell.
  5. Run the command peripheral.wrap('right').pullItems('left', 10, 1, 2) from the Lua shell.

Expected Results:
The item in slot 10 on the storage on the left is moved to the storage on the right, appearing in slot 2

Actual Results:
The item in slot 10 on the storage on the left is moved to the storage on the right, appearing in slot 1

Reproduced with:
Initially noticed on FTB Evolution 1.10.0 with settings left as default
Repeated with a clean installation of the following:

  • Minecraft 1.21.1
  • NeoForge 21.1.133
  • CC:Tweaked ver 1.115.1
  • Sophisticated Core ver 1.21.1-1.3.2.900
  • Sophisticated Storage ver 1.21.1-1.4.0.1077

--

This works as expected with vanilla Minecraft chests and I tried this with chest/storages from other mods (PneumaticCraft, Ars Nouveau, Functional Storage), and in those, the item appears in the expected slot, so I'm guessing Sophisticated Storage is doing something different from the norm. That said, if I'm mistaken and this would need to be reported to CC:Tweaked, let me know. If it's considered out-of-scope or a "won't fix" due to being related to integration with another mod, that's understandable, please just close this then

commented

This is a feature in Sophisticated where it inserts item to the first valid slot which necessarily isn't first slot - will try to stack with the same item in any other slot, put item into memorized slot, skip any memorized slots and put item in the first empty slot.

I am not really going to change this logic because there may be some small use case where players would want to use external mod to put items into specific slots. You can just use sophisticated features (memorized slots) to achieve the exact same thing - unless of course you mean that you want to put different kinds of items into a specific slot that wouldn't be doable but also seems like an extreme corner case.