Sophisticated Storage

Sophisticated Storage

36M Downloads

Storage display large item bug

Closed this issue ยท 11 comments

commented

Certain items appear to have a visual display bug with the sophisticated storage display

Example shown are the chemicals from ChemLib, the compounds from the same mod are unaffected as shown

Minecraft: 1.20.1
Forge: 47.4.0
Soph Storage: 1.3.49
Soph Core: 1.2.69

Image

Image

These dispaly normally elsewhere seemingly

Image

Image

Image

commented

How do these items show in a regular item frame? The display size / rotation and such is based on that.

commented

A tad large with some z fighting but nothing that looks too out of the ordinary

Image

commented

I wonder if forge is having the bug it used to have in the past - do blocks look correct in that barrel?

commented

Image

commented

So I took a closer look, but couldn't see what exactly is going here while debugging the rendering code. However they have the same issue when their items are placed in Functional Storage Drawers - just in this case they can still fit thanks to the fact that functional storage in general renders the items smaller on their drawers.
Anyway this is something for the mod dev of ChemLib to fix as we are just using FIXED transformation to show the item on barrels / drawers.

Image

commented

Interesting side note, storage drawers is unaffected

Image

commented

Certain other items are also affected it seems (Mekanism Atomic Disassembler)

Storage Drawers more normal on the left, Limited Barrel a bit large and protruding on the right
Image

Maybe the FIXED transformation isnt best suited for display at times?

commented

the fixed transform is absolutely alright for display, problem is when there's more rendering stuff happening that only seems to be adjusted for item frames specifically, the alternative is showing everything flat as in gui items as Storage Drawers do, but I like 3d models much more than that.

commented

Fair enough, thanks for your consideration

commented

actually I take it all back - I missed one thing that I am doing - if item's model is marked as 3d in gui I am making it larger scale. In vanilla and sophisticated this only applies to blocks and I want those to appear larger than they would otherwise, but if some mod's item is also marked as 3d in gui it will appear larger as well which is the case for disassembler here. I am going to fix this by only apply the larger scale to actual blocks.

commented

This is fixed in the latest release