Sophisticated Storage

Sophisticated Storage

36M Downloads

 [BUG] Critical Item Loss Bug Caused by Conflict Between Sophisticated-series Mods and CustomNPCs Mod / 关于精妙系列模组与CustomNPCs模组产生冲突导致的恶性吞物品Bug 

SYFabfic opened this issue · 11 comments

commented

以下为AI帮助翻译总结 如果出现歧义恳请以中文为准
The following is a summary of AI-assisted translation In case of ambiguity, please refer to the Chinese version as the standard.

Title(标题): [Bug] Dumping Upgrade causes item loss with limited barrels when GUI states are mismatched

Minecraft Version: 1.20.1
Mod Version: sophisticatedbackpacks-1.20.1-3.24.9.139
Forge/Fabric Version:
Other Relevant Mods: sophisticatedstorage-1.20.1-1.4.11.1344, sophisticatedcore-1.20.1-1.2.103.1220

Describe the bug(问题描述)
A serious bug causes items to be deleted (voided) when using a backpack with a Dumping Upgrade to dump items into a Limited Barrel (which has few slots and fills up easily).

Whether the items are lost or not depends solely on whether the GUI inventory screens of the backpack and the barrel have been opened before dumping.

To Reproduce(复现步骤)

  1. Equip a backpack with a Dumping Upgrade.
  2. Place a Limited Barrel.
  3. The item loss will occur under these specific conditions:
    • If the backpack's GUI has been opened BUT the barrel's GUI has NOT been opened (or vice versa).
    • The bug does NOT occur if both GUIs have been opened, or if neither has been opened.

Expected Behavior(预期行为)
Items should always be transferred into the barrel or remain in the backpack if there's no space. They should never be voided.

Additional Context(补充信息)
This is a very strange and critical bug, as item loss is one of the worst experiences for a player.

————————————————————

在使用同根同源的精妙背包模组时发生的相当诡异而又恶性的吞物品bug

以下是经过反复实验探寻出的大概规律

如果给背包装备了卸货升级插件然后手持背包对木桶进行卸货的话 如果这个木桶的格子已经占满(对于限类木桶来说 它们只有几个格子 所以永远是占满的或者更容易被占满)会有可能直接把物品吞掉
最令人不可思议的是物品会不会被吞掉居然取决于在进行卸货的时候有没有把背包拿在手上查看过里面的库存 并且还取决于你有没有查看过木桶
如果你用打包带把一个木桶刚放下而且并没有打开gui查看 然后你背包刚从地上拿到手里也没有打开gui查看 在卸货的时候就不会出现这种情况
反之 如果既查看了背包的gui也查看了箱子的gui也不会出现这种情况
而在两方被查看的状态不匹配时 则必定会吞掉物品
且经过测试 每次重进游戏这个查看状态都会被刷新

Image
commented

forge 1.20.1

commented

I can give any further information that might help resolve the issue as well in the future.

commented

又多次测试了几次 发现这些规则也不是一定成立的 可能还有其他条件 总之就是很诡异就是了
After testing several times again, I found that these rules are not necessarily valid. There may be other conditions, but in short, it's just very strange.

commented

这个问题不仅影响您正在使用的模组版本,也影响到最新发布的 1.20.1 版本模组,所以很遗憾,您只能等待问题修复。我已经在 1.21.1 版本上测试过相同的模组,物品不再被删除。1.20.1 版本仍然很流行,并且仍在维护中,所以我会尝试解决这个问题。

太棒了兄弟😭祝你成功,这会帮我大忙的,我也会尝试用我蹩脚的java知识看看能不能发现问题所在
That's awesome, bro! 😭 Wishing you success. This will be a huge help to me. I'll also try to use my limited Java knowledge to see if I can find the root cause of the issue.

commented

I have not been able to get this bug to occur for me with the conditions that have been shared. Are you able to share a screenshot of the barrel you are depositing to, a screenshot of inside the backpack you are using to deposit items, a screenshot of what happens after right-clicking the limited barrel, and a screenshot of the backpack afterwards? I am most interested in the text that appears on screen that says "10 stacks deposited to inventory" if you can include that in your screenshot.

Image Image Image Image

I have tried with various amounts of various items in my backpack without anything bad happening.

commented

I have not been able to get this bug to occur for me with the conditions that have been shared. Are you able to share a screenshot of the barrel you are depositing to, a screenshot of inside the backpack you are using to deposit items, a screenshot of what happens after right-clicking the limited barrel, 和 a screenshot of the backpack afterwards? I am most interested in the text that appears on screen that says "10 stacks deposited to inventory" if you can include that in your screenshot.

Image Image Image Image
I have tried with various amounts of various items in my backpack without anything bad happening.

你必须确保包里的每个格子都被填满。物品的数量和类型无关紧要,就像图片中一样。
You must ensure that every slot in the bag is filled. The quantity and type of items do not matter, just like in the picture.

Image Image Image Image Image

p1 木桶原状态
p2 背包原状态(截完这张图之后我需要把它放到地上再拿起来来刷新它的GUI被观察状态)
p3 进行卸货 显示的数字是真实的背包中同类物品的数量 而不是理应被堆叠的数量 此时吞物品已经发生 (例如 背包中有26*64+60个A物品 也就是还能容纳1堆物品 背包中有三组A物品 此时堆叠不会显示理应被堆叠的1 而是背包中实际有的3 此时吞物品便已经发生)
p4 背包之后的状态 物品已经消失
p5 木桶之后的状态 可以看见卸货并未进行

p1 Original state of the barrel
p2 Original state of the backpack (After taking this screenshot, I need to place it on the ground and pick it up again to refresh its GUI observation status“)
p3 Unloading process — The number displayed is the actual count of the same type of item in the backpack, not the amount that should have been stacked. At this point, item loss has already occurred. (For example, if the backpack contains 26*64+60 of item A, meaning it can still hold 1 more stack, but the backpack currently has 3 stacks of item A. The stacking display will not show the expected number 1, but the actual number 3 in the backpack. At this point, item loss has already occurred. )
p4 State of the backpack afterward — The items have disappeared.
p5 State of the barrel afterward — It can be seen that unloading did not proceed.

commented

我无法在共享的条件下为我发生这个错误。您是否可以分享您要存放物品的桶的屏幕截图、用于存放物品的背包内部的屏幕截图、右键单击有限桶后发生的情况的屏幕截图以及之后背包的屏幕截图?我最感兴趣的是屏幕上显示的文字“10 堆存放到库存”,如果您可以将其包含在屏幕截图中。

图像 图像 图像 图像
我尝试过在背包里放各种数量的各种物品,没有发生任何不好的事情。

你需要尝试把背包放到地上再拿起来 拿起来之后就不要再打开背包查看gui了 如果不行 就保证木桶不变的情况下重复上面的操作 但是改为查看一次gui
如果需要的话我会录个视频 但是我不清楚怎么样让你们看到这个视频 github是支持上传视频的吗
You need to try putting the backpack on the ground and then picking it up. After picking it up, don't open the backpack to check the GUI again. If that doesn't work, repeat the procedure above while keeping the barrel unchanged, but this time check the GUI only once.
If needed, I can record a video, but I'm not sure how to let you view it. Does GitHub support video uploads?

commented

The screenshots and descriptions are very informative, thank you. I have followed the instructions given on the same mod version and after trying it, none of the items are being deleted from the backpack. Everything that fits in the barrel is correctly stored, and everything else that does not fit remains safely in the backpack.

If there are other mods installed, the issue may be caused by something else that is installed at the same time. Even if that is the case, I hope we can find the issue and write a fix here for it. Do you have a list of other mods that are also installed? If this issue is happening when using a published collection of mods, the name of that collection or a website link for the collection would be useful as well.

commented

The screenshots and descriptions are very informative, thank you. I have followed the instructions given on the same mod version and after trying it, none of the items are being deleted from the backpack. Everything that fits in the barrel is correctly stored, 和 everything else that does not fit remains safely in the backpack.

If there are other mods installed, the issue may be caused by something else that is installed at the same time. Even if that is the case, I hope we can find the issue and write a fix here for it. Do you have a list of other mods that are also installed? If this issue is happening when using a published collection of mods, the name of that collection or a website link for the collection would be useful as well.

我发现问题所在了 是一个叫做自定义NPC的模组导致的,,,
I've found the problem—it's caused by a mod called Custom NPCs,,,,,,,,,,,,,,,,
https://www.mcmod.cn/class/15373.html
https://www.curseforge.com/minecraft/mc-mods/customnpcs-unofficial

[自定义NPC 非官方版] CustomNPCs-1.20.1-GBPort-Unofficial-20250830

commented

That has worked! it now happens exactly as you've described with the items being deleted only when the backpack is picked up again. Thank you for reporting this bug. I will see if I can figure out what is happening in the code when the backpack is placed and picked up.

commented

The issue is affecting the mod versions you are using as well as the most recent versions released for 1.20.1, so unfortunately you will have to wait for the problem to be fixed. I have tested with the same mods installed on version 1.21.1 and the items are no longer being deleted. 1.20.1 is still popular and supported so I will see what I can do there.