Soul Shards Respawn

Soul Shards Respawn

5M Downloads

allowFakePlayers not counting Turtles

Savag3life opened this issue ยท 4 comments

commented

I assume this setting means that turtles should be able to level up a soul shard.

commented

So what would that be for? I can't seem to find any kind of Fake Player killing tool. At least none that support and inventory to store the shard. If you could just point me in the direction of the mod that this function was intended for, I'll be all set.

commented

Additionally, could I suggest adding turtle support?

commented

The function is intended for any mod using a proper FakePlayer. I don't know any off the top of my head. I don't plan to add specific CC support.

commented

This means that turtles are not proper fake players. The check is literally just instanceof FakePlayer. https://github.com/TehNut/Soul-Shards-Respawn/blob/1.12.2/src/main/java/info/tehnut/soulshardsrespawn/core/EventHandler.java#L41