
Juke box
simplebunsen opened this issue · 6 comments
Using the latest version, and the jukebox doesn't seem to be affected by mod sound mechanics at all, except for randomly muting/sounding muffled when pressing escape to pause in singleplayer. Another pause unpause cycle fixes it.
I'm unsure what info I can provide to help you fix it...
The jukebox isn't supposed to be affected by sound physics, because of how it is implemented, the environment would only be calculated once when the jukebox starts playing and would not get muffled when going behind walls or the reverb wouldn't change when remove and adding blocks. (Although it update the environment with the dynamic environment evaluation, i still don't recommend using it)
Pause bug @simplebunsen was talking about is the effect of environment being recalculated after pausing the game.
Steps to reproduce:
- Place Jukebox inside closed area and put music disc in it.
- Leave that area or just do anything to change sound effect conditions — played music is not affected.
- Pause game and then un-pause it — now playing music is affected by new conditions.
It seems that it can be possible to make jukebox be affected by sounds physics (do refresh several times per second, not sure how that would affect game performance though), or just fix refreshing after pause (although this way it won't bee that cool)