Large performace drop from 1.19 to 1.19.1 when experiencing many sounds.
Dahkahtah opened this issue · 11 comments
Apologies if this is not considered a bug or if this is merely a result of changes on Mojang's side.
Bug description
Performance (specifically FPS) has been reduced between recent versions of the mod, noticed around large piston-based redstone machine and recreated using a large array of noteblocks
This can be mitigated by using Mod Menu & Cloth Config to change the settings to reduce performance impact in 1.19.1, but I thought it worthwhile to document the difference in the mod's performance nonetheless.
Steps to reproduce the issue
You can view my video to view the exact process I used to produce this issue, though I'm sure the effects will vary by computer.
https://youtu.be/3OPNwm-MUtU
(Timestamps for when the worlds load are in the pinned comment)
- Create a scenario where minecraft is producing many sounds at once
- Compare performance between version 1.0.6 for 1.19 and 1.0.11 for 1.19.1
Log files
1.19 log file
1.19.1 log file
Versions
- Minecraft version: 1.19.1
- Forge/Fabric version: 0.14.8
- Mod version: 1.0.11
- Minecraft version: 1.19
- Forge/Fabric version: 0.14.8
- Mod version: 1.0.6
Other mods
No other mods were installed.
Screenshots (Optional)
Here are two screenshots (from the video mentioned above) that show performance differences between the two versions
1.19.1/1.0.11 F3 Menu:
1.19/1.0.6 F3 Menu:
End Note
I fell in love with the mod when I was first recommended it when playing on a server with voice chat, experiencing the reverberation makes caving in this game much more rich and immersive. I appreciate all the work you do to maintain and update it!
Strange, thanks for looking into it. I'll try to isolate what else could be causing this issue on my device.
I can't really see any difference between those versions...
1.19-1.0.10
1.19.1-1.0.11
Your issue might be related to #57. Please try if it still happens with version 1.0.12
Can also reproduce. 1.0.10 has no lag, but 1.10.11 and onwards do.
Tested on 1.19, fabric 0.14.9, and mod versions 1.0.10 and 1.0.13. No other mods installed.
It is also felt especially strongly on farms, there are no special drawdowns at 1.19, but at 1.19.2 fps sagging to 1.
1.19 with Sound Physics Remastered 1.0.10 - https://youtu.be/JSsNP7QlFRM
1.19.2 with Sound Physics Remastered 1.0.13 - https://youtu.be/FU6DkZU4QQ4
I might have found the cause. Please update to 1.0.14 and disable this config option:
Yea, it works, thanks.
Maybe it would be better to disable this default parameter in fashion?