Beyond Earth: Giselle Addon

Beyond Earth: Giselle Addon

2M Downloads

Alien Trades shows barrier instead of empty

LegendaryTot opened this issue ยท 5 comments

commented

Minecraft Version

1.18.1

Forge Version

39.0.9

Space-BossTools or Beyond Earth Version

1.18.1-5.9c

Addon Mod Version (This Mod)

1.18.1-1.2

The details

Alien Trades shows a barrier for some reason (i guess meaning item not needed)... Could that be changed to be empty like JER Villager Trades does it?

image

commented

Yes, it meaning 'no needed'

If there is a mix of 1 and 2 items required for the same level,
It doesn't show up properly in the trade list (structural problem in jei, jer)

For example, if villager has the following trade list at the same level,

  1. Diamond x1 => Emerald x1
  2. Diamond x2 + Bread x1 => Emerald x2

JER shows as below

  1. Diamond x1 + Bread x1 => Emerald x1
  2. Diamond x2 + Bread x1 => Emerald x2

For this reason, i added a barrier to show the exact required item.
Then how about set barrier's displayname as "Not needed"?

And i can don't show barrier when all trades don't need second item in same level

commented

i will patch to like below

mostly
image

min in same level 1 items and 2 items trades
image

commented

Ah I see. I didn't realize there was an issue with overlapping trades at same level for JER. Yeah maybe renaming the barrier to "Not Needed" might be less confusing (I saw it and was like how do I get a barrier).

commented

yh, good idea

commented

it done (a7c5c1c)
thanks for your attention
image