Line numbers
hafarooki opened this issue ยท 9 comments
Would it be possible to show line numbers instead of method names like massivelag?
Uhh, it would technically be possible yes, but I don't really see what the benefit would be.
Most other Java profilers/samplers don't include this information in their output - you can infer the line numbers just by looking for the method call.
Unless you call the method more than once in one method, especially with collections
https://i.imgur.com/VOI7Dl5.png this lets you see WHICH call to it is causing lag in cases when one call is using more time than others
I've basically finished implementing this, but don't like the way it's turned out.
The line number of each stack node isn't the line of the method, it's where the next call was invoked from - which results in a particularly useless division of the data.
All of those line numbers above just mean that there was an outgoing call on that line - not useful at all in this context.
No it doesn't, it tells you the line of the outgoing call in that method, in other words, where the next (child) method in the stack was called from.
Would it tell you which line number, for example, HashSet.add was being called from if you wer adding it from different places? If not then yeah it's not helpful
Added (in a slightly different & more successful way) in 7a60c09