spark

spark

95M Downloads

Servers getting stuck on stop [1.19.2-1.10.17-forge]

Mitchell5200 opened this issue ยท 7 comments

commented

Hi i've found an issue where spark seems to be preventing servers from properly shutting down when the stop command is issued. I've tested with and without spark in the modpack, and this only seems to occur when spark is in the pack

Modpack ATM8, 1.0.6b
Forge 43.1.55
Spark 1.19.2-1.10.17-forge

VisualVM threaddump txt file copy below
server threaddump1.txt

Images attached below
Screenshot 2022-12-21 10 39 48
Screenshot 2022-12-21 10 45 08
Screenshot 2022-12-21 11 14 25

commented

Hmmm

That thread is a daemon thread, so shouldn't prevent the process from exiting:

Thread thread = Executors.defaultThreadFactory().newThread(r);
thread.setName("spark-monitor");
thread.setDaemon(true);

commented

+1
forge 1.19.2 43.1.57
spark 1.10.17
Only spark installed.

commented

Also happens with spark 1.10.17 on fabric loader 0.14.12
That prevents auto restarts, which doesn't include a kill after a wait time.

commented

Also happens with spark 1.10.26 on fabric loader 0.14.12
Here's a threaddump: https://hastebin.com/aqetiyohex.pl
The spark-worker threads are in state WAITING

commented

Seems to also happen on Fabric servers:
fabricloader 0.14.13 (1.19.3)
spark-1.10.17

Server running AMP 2.4.1.2

(Removing the spark-mod from the mod-folder, does provide a proper shutdown/restart. When include, stop/restart just hangs. Process Java keeps running at high cpu-load.)

commented

Same here with
fabricloader 0.14.13 (1.19.3)
spark-1.10.29

commented

Apologies for a bump of this issue thread.
This error still happens in the latest version that's on CurseForge (at least for Fabric which I have tested).

What is your CurseForge upload schedule, I only ask because this was fixed in >= v1.10.36 but modpack authors who download mods directly from CurseForge are unable to have this problem fixed as the fixed version is not automatically obtainable from the CurseForge repo.

Any chance of an upload/update to that repo?

Many thanks!