spark

spark

Mods
95M Downloads

Unable to use sparkc or sparkclient commands

Mr-LemonLime opened this issue · 4 comments

commented

Description

I am unable to any sparkc or sparkclient but can use spark just fine.

Reproduction Steps

go into minecraft 1.18.2 and type /sparkc profiler start or /sparkclient profiler start, nothing will be outputted in console, logs or chat. but /spark profiler open works just fine. Same issue is for any other sparkc and sparkclient commands

Expected Behaviour

to start the command as expected, similar to the manner of /spark profiler open

Platform Information

  • Minecraft Version: 1.18,2
  • Platform Type: Client
  • Platform Brand: Forge
  • Platform Version: 40.2.9 and 40.2.17

Spark Version

v1.10.38

Logs and Configs

https://mclo.gs/MBX8gOF

Extra Details

No response

commented

Same here on 1.18.2 / forge 40.2.13. Downgrading Spark from 1.10.38 to 1.9.11 fixes the issue.

This solved the issue for me as well. So there must be something in newest release that breaks the mod. Perhaps just for linux since it doesnt work for me on Pop Os but do work for my son on windows 11.

commented

spark/spark-forge/src/main/java/me/lucko/spark/forge/plugin/ForgeClientSparkPlugin.java

Lines 86 to 94 in 8b6c266

public int run(CommandContext<CommandSourceStack> context) throws CommandSyntaxException {
String[] args = processArgs(context, false, "sparkc", "sparkclient");
if (args == null) {
return 0;
}
this.platform.executeCommand(new ForgeCommandSender(context.getSource().getEntity(), this), args);
return Command.SINGLE_SUCCESS;
}

spark/spark-forge/src/main/java/me/lucko/spark/forge/plugin/ForgeSparkPlugin.java

Lines 164 to 168 in 8b6c266

protected static String[] processArgs(CommandContext<?> context, boolean tabComplete, String... aliases) {
String[] split = context.getInput().split(" ", tabComplete ? -1 : 0);
if (split.length == 0 || !Arrays.asList(aliases).contains(split[0])) {
return null;
}

The return value of context.getInput() has preceding slash in MC 1.18 which has been trimmed above MC 1.19.

commented

Same here on 1.18.2 / forge 40.2.13. Downgrading Spark from 1.10.38 to 1.9.11 fixes the issue.

[22Jan2024 02:11:25.247] [Server thread/DEBUG] [net.minecraftforge.common.ForgeHooks/WP]: Gathering id map for writing to world save sparkc profiler memory test
[22Jan2024 02:11:25.278] [Server thread/DEBUG] [net.minecraftforge.common.ForgeHooks/WP]: ID Map collection complete sparkc profiler memory test
[22Jan2024 02:11:27.989] [ForkJoinPool.commonPool-worker-17/ERROR] [net.minecraftforge.eventbus.EventSubclassTransformer/EVENTBUS]: Could not find parent me/lucko/spark/lib/protobuf/GeneratedMessageLite for class me/lucko/spark/proto/SparkWebSocketProtos$RawPacket in classloader jdk.internal.loader.ClassLoaders$AppClassLoader@73d16e93 on thread Thread[ForkJoinPool.commonPool-worker-17,10,main]
[22Jan2024 02:11:27.989] [ForkJoinPool.commonPool-worker-17/ERROR] [net.minecraftforge.eventbus.EventSubclassTransformer/EVENTBUS]: An error occurred building event handler
java.lang.ClassNotFoundException: me.lucko.spark.lib.protobuf.GeneratedMessageLite
	at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[?:?]

Logs : debug.log

  • 👍1
commented

Same here on 1.18.2 / forge 40.2.13. Downgrading Spark from 1.10.38 to 1.9.11 fixes the issue.

Downgrading from spark 1.10.38 to spark 1.9.11 on MC 1.18.2 + Forge 40.2.17 also fixed this issue for me.