Starting sampler from in-game can leak memory
aromaa opened this issue ยท 1 comments
Description
There are few lambdas in the SamplerModule that will hold the reference of the command sender until the sampler is turned off. For example this and this. This can be a problem if the command sender logs off and leaves the sampler on which causes the corresponding player object and the world they were in to be leaked.
Reproduction Steps
Start the sampler in-game and log off, the player object is leaked.
Expected Behaviour
The player object is not leaked.
Platform Information
- Minecraft Version: 1.20.6
- Platform Type: server
- Platform Brand: Sponge
- Platform Version: 1.20.6-11.0.1-RC1661
Spark Version
v1.10.73
Logs and Configs
No response
Extra Details
No response
