Description

When trying to build a server with NeoForge + Spark + SpongeNeo, I'm seeing this JPMS error:

Exception in thread "main" java.lang.module.ResolutionException: Modules spark and net.kyori.adventure.text.serializer.gson export package net.kyori.adventure.text.serializer.gson.impl to module cosmeticarmorreworked

Naturally, SpongeNeo ships an adventure implementation by itself, so when the JPMS loads services, it seems that Spark's jar also contains the same services manifests, even though spark's jar doesn't ship adventure.

I believe this isn't rectifiable from Sponge's side as we appropriately include the libraries through a loading mechanism. I believe this should be a simple fix on Spark's building process to exclude the services when creating the final jar.

Reproduction Steps

1. Download SpongeNeo 1.21.1-21.1.35-12.0.0 and Spark 1.10.109 onto a NeoForge server
2. Run the server
3. JPMS module error prevents server startup

Expected Behaviour

Should be able to start the server

Platform Information

• Minecraft Version: 1.21.1
• Platform Type: server
• Platform Brand: NeoForge
• Platform Version: NeoForge 21.1.97

Spark Version

v1.10.109

Logs and Configs

https://gist.github.com/gabizou/0bb38bf9f38e0b317c0166c5c6f41922

Extra Details

No response

I think this is a duplicate of #460. The issue has been resolved for MC 1.21.1 but sadly I can't find any release of the fix before MC 1.21.2

Also of #478 - I have released a backported fix here:

https://modrinth.com/mod/spark/version/v5qtqRQi
https://legacy.curseforge.com/minecraft/mc-mods/spark/files/6225208

Please could you test & confirm that the updated build fixes the problem? :)

I confirm it works. Thanks a lot for the backport!

Sweet, thanks!