Spartan Compatibility

Spartan Compatibility

1M Downloads

[BUG] none of the material bonuses on aether longbows work

elephantae opened this issue ยท 2 comments

commented

None of the material bonuses having to do with skyroot longbow, skyroot crossbow, holystone longbow, holystone crossbow, zanite longbow, zanite crossbow, gravitite crossbow or gravitite longbow function, on shot or melee hit.

skyrootbug2
(sorry for the low quality, github has a 10mb limit)
the bug was demonstrated with skyroot because it is the easiest to show but none of the bonuses work.

From a conversation with a friend:
i think its caused by the fact that you use a material with the weaponproperty, but then the weapon has another callback that does the same thing as the property

i found proof that that config (both the mat and the weapon applying) does not work
if you look at spartanweaponry arcana
specifcally their item registry file
the weapon-specific properties in each constructor are commented out

(not me, thanks democat)

commented

Mod looks dead. No point.

commented

Firstly, there is no reason to comment the same thing on multiple issues just because the repository hasn't had a commit - secondly, there is still a possibility for pull requests - and thirdly, if you have nothing to contribute to these issues, it's not worth saying anything, we can observe that the repository is currently inactive.