Spartan Weaponry

Spartan Weaponry

34M Downloads

Addons need their own translations for trait types

KreloX opened this issue ยท 4 comments

commented

in WeaponTrait.initTooltipTypes the trait type component should always use Spartan Weaponry's modid, not the addon's one.

Currently, all addons wishing to add a new trait using the api need to either have their own translations for "melee", "throwing", etc. or use a workaround.

commented

Oh good find! My bad. I'll push a fix for this whenever I can.

commented

Also, in ModelGenerator.createMeleeWeaponModels the coating textures should always use the spartanweaponry id too.
texture("coating", coatingTexture.getPath()) should be texture("coating", coatingTexture)

commented

Noted and fixed! I just need to review what else needs to be fixed and if the API changes break anything before I push the next 1.20.1 update.

commented

The new version with these fixes is live now!
I've tested the fixes I've made with this issue and your other one with your existing addon mods and it doesn't appear to have broken anything.
Thanks for letting me know about these again.
Closing issue