Spectrum

Spectrum

2M Downloads

[BUG] Blaze killed by Midnight Resolution may not drop Midnight Chip

Mosklia opened this issue ยท 3 comments

commented

Describe the bug

Blaze killed by Midnight Resolution may not drop Midnight Chip and Blaze Rod.
It seems that these blaze was killed by "touching non-lava fluid", or say their death source is minecraft:drawn.

To Reproduce

  1. Find a Blaze Spawner
  2. Build a wall to make sure blazes spawn inside the wall
  3. Place a bucket of midnight resolution on the spawner
  4. Place a Black Hole Chest to collect their droppings
  5. You may see that some blazes (not all) died without dropping anything

Expected behavior

All blazes should drop a midnight chip.

Mod version

1.7.0-deeper-down-alpha-16

Screenshots

No screenshots

Crash Report

No crash

commented

The issue was that it was conflicting with some other mixins for swimming. It's fixed for the next version.

commented

I tried to debug with datapack, the find that Minecraft 1.19.2 does not support my loot table:
minecraft:entities/blaze

{
  "type": "minecraft:entity",
  "pools": [
    {
      "bonus_rolls": 0.0,
      "conditions": [
        {
          "condition": "minecraft:killed_by_player"
        }
      ],
      "entries": [
        {
          "type": "minecraft:item",
          "functions": [
            {
              "add": false,
              "count": {
                "type": "minecraft:uniform",
                "max": 1.0,
                "min": 0.0
              },
              "function": "minecraft:set_count"
            },
            {
              "count": {
                "type": "minecraft:uniform",
                "max": 1.0,
                "min": 0.0
              },
              "function": "minecraft:looting_enchant"
            }
          ],
          "name": "minecraft:blaze_rod"
        }
      ],
      "rolls": 1.0
    },
    {
        "bonus_rolls": 0.0,
        "rolls": 1.0,
        "conditions": [
            {
                "condition": "minecraft:damage_source_properties",
                "predicate": {
                    "tags": [
                        {
                            "expected": true,
                            "id": "minecraft:drawn"
                        }
                    ]
                }
            }
        ],
        "entries": [
            {
                "type": "minecraft:item",
                "functions": [
                    {
                        "function": "minecraft:set_count",
                        "count": 1
                    }
                ],
                "name": "minecraft:apple"
            }
        ]
    }
  ]
}
commented

I think a mixin to the end of net.minecraft.entity.LivingEntity::tickMovement() would help.